Support Reset connection for VNG and Vwan #14225
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
please sync with network-november branch, you might not need to check in the local SDK.. |
akshatkale
requested review from
MS-syh2qs,
Sandido,
bilaakpan-ms,
dkulkarni-ms,
grizzlytheodore,
haagha and
madewithsmiles
as code owners
@VeryEarly - Synced with network-november branch but local SDK from #14182 wasn't compatible with my changes so checked-in new Network SDK version which works with both the PRs. |
VeryEarly
reviewed
Feb 24, 2021
| [Cmdlet( | ||
| VerbsCommon.Reset, | ||
| ResourceManager.Common.AzureRMConstants.AzureRMPrefix + "VpnSiteLinkConnection", | ||
| DefaultParameterSetName = "ByName"), |
There was a problem hiding this comment.
Suggested change
| DefaultParameterSetName = "ByName"), | |
| DefaultParameterSetName = "ByName", | |
| SupportsShouldProcess = true), |
| using Microsoft.Azure.Management.Network.Models; | ||
| using Newtonsoft.Json; | ||
|
|
||
| [Cmdlet("Reset", ResourceManager.Common.AzureRMConstants.AzureRMPrefix + "VirtualNetworkGatewayConnection", DefaultParameterSetName = "ByName"), OutputType(typeof(void))] |
There was a problem hiding this comment.
Suggested change
| [Cmdlet("Reset", ResourceManager.Common.AzureRMConstants.AzureRMPrefix + "VirtualNetworkGatewayConnection", DefaultParameterSetName = "ByName"), OutputType(typeof(void))] | |
| [Cmdlet("Reset", ResourceManager.Common.AzureRMConstants.AzureRMPrefix + "VirtualNetworkGatewayConnection", DefaultParameterSetName = "ByName", SupportsShouldProcess = true), OutputType(typeof(void))] |
There was a problem hiding this comment.
|
Hi @VeryEarly, can we get this PR checked in today if everything looks good? |
VeryEarly
approved these changes
Feb 25, 2021
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Checklist
CONTRIBUTING.mdChangeLog.mdfile(s) has been updated:ChangeLog.mdfile can be found atsrc/Network/Network/ChangeLog.md## Upcoming Releaseheader -- no new version header should be added