Skip to content

[Storage] Add breaking change warning for Remove-AzRmStorageShare #14797

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 22, 2021
Merged

[Storage] Add breaking change warning for Remove-AzRmStorageShare #14797

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions src/Storage/Storage.Management/ChangeLog.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,8 @@
- `New-AzStorageAccount`
* Fixed an issue that delete immutable blob will prompt incorrect message.
- `Remove-AzStorageAccount`
* Added breaking change warning message for upcoming cmdlet breaking change
- `Remove-AzRmStorageShare`

## Version 3.5.1
* Fixed copy blob fail with source context as Oauth [#14662]
Expand Down
2 changes: 2 additions & 0 deletions src/Storage/Storage.Management/File/RemoveAzureStorageShare.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,13 +16,15 @@
using Microsoft.Azure.Management.Internal.Resources.Utilities.Models;
using Microsoft.Azure.Management.Storage;
using Microsoft.Azure.Management.Storage.Models;
using Microsoft.WindowsAzure.Commands.Common.CustomAttributes;
using System;
using System.Collections;
using System.Collections.Generic;
using System.Management.Automation;

namespace Microsoft.Azure.Commands.Management.Storage
{
[GenericBreakingChange("Currently if the share has snapshots, snapshots will be removed together with the share. In a future release, snapshots will not be removed by default, need specify new parameter '-IncludeAllSnapshot' to remove snapshots together.")]
[Cmdlet("Remove", ResourceManager.Common.AzureRMConstants.AzureRMStoragePrefix + StorageShareNounStr, DefaultParameterSetName = AccountNameParameterSet, SupportsShouldProcess = true), OutputType(typeof(bool))]
public class RemoveAzureStorageShareCommand : StorageFileBaseCmdlet
{
Expand Down