Skip to content

Service fabric Managed Clusters - Update managed .net sdk for api version 2021-05-01 #14807

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Apr 23, 2021
Merged

Service fabric Managed Clusters - Update managed .net sdk for api version 2021-05-01 #14807

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
27890f4
update managed sdk to ga version and update cmdlets
Apr 21, 2021
1f17823
update managed tests
Apr 21, 2021
c4cca24
runtest agains the test region and add params to PS objects
Apr 21, 2021
b495589
record managed cluster tests
Apr 22, 2021
a01c53b
record managed app tests and update changelog
Apr 22, 2021
67dc4ac
rename plural parameters and update help documents
Apr 22, 2021
e472732
fix change log param names
Apr 22, 2021
1757446
breaking change and signature issue exceptions
Apr 22, 2021
6927b62
add breaking change message for PSManagedService
Apr 22, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 1 addition & 3 deletions ...eFabric/ServiceFabric.Test/ScenarioTests/ServiceFabricManagedClustersApplicationTests.ps1
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -248,14 +248,12 @@ function Test-ManagedService
Assert-AreEqual $standByReplicaKeepDuration $statefulService.Properties.StandByReplicaKeepDuration
Assert-AreEqual $servicePlacementTimeLimit $statefulService.Properties.ServicePlacementTimeLimit

$instanceCloseDelayDuration = "00:11:00"
$minInstancePercentage = 20
$minInstanceCount = 2

$statelessService = $statelessServiceFromGet | Set-AzServiceFabricManagedClusterService -Stateless -InstanceCloseDelayDuration $instanceCloseDelayDuration -MinInstancePercentage $minInstancePercentage `
$statelessService = $statelessServiceFromGet | Set-AzServiceFabricManagedClusterService -Stateless -MinInstancePercentage $minInstancePercentage `
-MinInstanceCount $minInstanceCount -Verbose
Assert-AreEqual "Succeeded" $statelessService.Properties.ProvisioningState
Assert-AreEqual $instanceCloseDelayDuration $statelessService.Properties.InstanceCloseDelayDuration
Assert-AreEqual $minInstancePercentage $statelessService.Properties.MinInstancePercentage
Assert-AreEqual $minInstanceCount $statelessService.Properties.MinInstanceCount

Expand Down
43 changes: 28 additions & 15 deletions src/ServiceFabric/ServiceFabric.Test/ScenarioTests/ServiceFabricManagedClustersTests.ps1
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,22 +17,25 @@ function Test-CreateBasicCluster
$resourceGroupName = "sfmcps-rg-" + (getAssetname)
$clusterName = "sfmcps-" + (getAssetname)
$pass = (ConvertTo-SecureString -AsPlainText -Force "TestPass1234!@#")
$location = "northeurope"
$location = "southcentralus"
$testClientTp = "123BDACDCDFB2C7B250192C6078E47D1E1DB119B"
Assert-ThrowsContains { Get-AzServiceFabricManagedCluster -ResourceGroupName $resourceGroupName -Name $clusterName } "NotFound"

$cluster = New-AzServiceFabricManagedCluster -ResourceGroupName $resourceGroupName -ClusterName $clusterName -Location $location `
-AdminPassword $pass -Sku Basic -ClientCertThumbprint $testClientTp -Verbose
Assert-AreEqual "Succeeded" $cluster.ProvisioningState
Assert-AreEqual "WaitingForNodes" $cluster.ClusterState
Assert-AreEqual "Succeeded" $cluster.ProvisioningState
Assert-AreEqual "Automatic" $cluster.ClusterUpgradeMode
Assert-AreEqual "Wave0" $cluster.ClusterUpgradeCadence

$pnt = New-AzServiceFabricManagedNodeType -ResourceGroupName $resourceGroupName -ClusterName $clusterName -Name pnt -InstanceCount 5 -DiskType Standard_LRS -Primary
Assert-AreEqual 5 $pnt.VmInstanceCount
Assert-AreEqual "Standard_LRS" $pnt.DataDiskType

$pnt = New-AzServiceFabricManagedNodeType -ResourceGroupName $resourceGroupName -ClusterName $clusterName -Name pnt -InstanceCount 5 -Primary

# shouldn't be allowed to remove the only primary node type in the cluster
Assert-ThrowsContains { $pnt | Remove-AzServiceFabricManagedNodeType } "InvalidParameter"

$cluster = Get-AzServiceFabricManagedCluster -ResourceGroupName $resourceGroupName -Name $clusterName
Assert-AreEqual "Deploying" $cluster.ClusterState
Assert-AreEqual "Deploying" $cluster.ClusterState

# scale primary node type
$pnt = Set-AzServiceFabricManagedNodeType -ResourceGroupName $resourceGroupName -ClusterName $clusterName -Name pnt -InstanceCount 6
Expand All @@ -48,22 +51,32 @@ function Test-NodeTypeOperations
{
$resourceGroupName = "sfmcps-rg-" + (getAssetname)
$clusterName = "sfmcps-" + (getAssetname)
$location = "northeurope"
$location = "southcentralus"
$testClientTp = "123BDACDCDFB2C7B250192C6078E47D1E1DB119B"
$pass = (ConvertTo-SecureString -AsPlainText -Force "TestPass1234!@#")
Assert-ThrowsContains { Get-AzServiceFabricManagedCluster -ResourceGroupName $resourceGroupName -Name $clusterName } "NotFound"

$cluster = New-AzServiceFabricManagedCluster -ResourceGroupName $resourceGroupName -ClusterName $clusterName -Location $location `
$cluster = New-AzServiceFabricManagedCluster -ResourceGroupName $resourceGroupName -ClusterName $clusterName -UpgradeMode Automatic -UpgradeCadence Wave1 -Location $location `
-AdminPassword $pass -Sku Standard -ClientCertThumbprint $testClientTp -Verbose
Assert-AreEqual "Succeeded" $cluster.ProvisioningState
Assert-AreEqual "WaitingForNodes" $cluster.ClusterState
Assert-AreEqual "Succeeded" $cluster.ProvisioningState
Assert-AreEqual "WaitingForNodes" $cluster.ClusterState
Assert-AreEqual "Automatic" $cluster.ClusterUpgradeMode
Assert-AreEqual "Wave1" $cluster.ClusterUpgradeCadence

New-AzServiceFabricManagedNodeType -ResourceGroupName $resourceGroupName -ClusterName $clusterName -Name pnt -InstanceCount 5 -Primary -AsJob
New-AzServiceFabricManagedNodeType -ResourceGroupName $resourceGroupName -ClusterName $clusterName -Name snt -InstanceCount 6 -AsJob
New-AzServiceFabricManagedNodeType -ResourceGroupName $resourceGroupName -ClusterName $clusterName -Name pnt -InstanceCount 5 -Primary -DiskType Premium_LRS -VmSize "Standard_DS2" -AsJob
New-AzServiceFabricManagedNodeType -ResourceGroupName $resourceGroupName -ClusterName $clusterName -Name snt -InstanceCount 6 -IsStateless -AsJob

#wait for nodetypes
WaitForAllJob

$pnt = Get-AzServiceFabricManagedNodeType -ResourceGroupName $resourceGroupName -ClusterName $clusterName -Name pnt
Assert-AreEqual "Premium_LRS" $pnt.DataDiskType
Assert-False { $pnt.IsStateless }

$snt = Get-AzServiceFabricManagedNodeType -ResourceGroupName $resourceGroupName -ClusterName $clusterName -Name snt
Assert-AreEqual "StandardSSD_LRS" $snt.DataDiskType
Assert-True { $snt.IsStateless }

$restart = Restart-AzServiceFabricManagedNodeType -ResourceGroupName $resourceGroupName -ClusterName $clusterName -Name snt -NodeName snt_0, snt_1 -PassThru
Assert-True { $restart }

Expand All @@ -85,15 +98,15 @@ function Test-CertAndExtension
{
$resourceGroupName = "sfmcps-rg-" + (getAssetname)
$clusterName = "sfmcps-" + (getAssetname)
$location = "northeurope"
$location = "southcentralus"
$testClientTp = "123BDACDCDFB2C7B250192C6078E47D1E1DB119B"
$pass = (ConvertTo-SecureString -AsPlainText -Force "TestPass1234!@#")
Assert-ThrowsContains { Get-AzServiceFabricManagedCluster -ResourceGroupName $resourceGroupName -Name $clusterName } "NotFound"

$cluster = New-AzServiceFabricManagedCluster -ResourceGroupName $resourceGroupName -ClusterName $clusterName -Location $location `
-AdminPassword $pass -Sku Standard -ClientCertThumbprint $testClientTp -Verbose
Assert-AreEqual "Succeeded" $cluster.ProvisioningState
Assert-AreEqual "WaitingForNodes" $cluster.ClusterState
Assert-AreEqual "Succeeded" $cluster.ProvisioningState
Assert-AreEqual "WaitingForNodes" $cluster.ClusterState

$pnt = New-AzServiceFabricManagedNodeType -ResourceGroupName $resourceGroupName -ClusterName $clusterName -Name pnt -InstanceCount 5 -Primary

Expand Down
2 changes: 1 addition & 1 deletion src/ServiceFabric/ServiceFabric.Test/ServiceFabric.Test.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@
<PackageReference Include="Microsoft.Azure.KeyVault" Version="3.0.1" />
<PackageReference Include="Microsoft.Azure.KeyVault.WebKey" Version="3.0.1" />
<PackageReference Include="Microsoft.Azure.Management.ServiceFabric" Version="1.3.0" />
<PackageReference Include="Microsoft.Azure.Management.ServiceFabricManagedClusters" Version="1.0.0-beta.1" />
<PackageReference Include="Microsoft.Azure.Management.ServiceFabricManagedClusters" Version="1.0.0" />
</ItemGroup>

<ItemGroup>
Expand Down
Loading