Skip to content

Conversation

patchin404
Copy link
Contributor

Description

The example for Enable-AzCdnCustomDomainCustomHttps calls New-AzCdnManagedHttpsParameters with TLS12 as the ProtocolType even though that is an invalid value. I'm replacing the ProtocolType value with ServerNameIndication, which is one of the two valid values (ServerNameIndication and IPBased).

Checklist

  • SHOULD select appropriate branch. Cmdlets from Autorest.PowerShell should go to generation branch.
  • SHOULD make the title of PR clear and informative, and in the present imperative tense.
  • SHOULD update ChangeLog.md file(s) appropriately
    • For any service, the ChangeLog.md file can be found at src/{{SERVICE}}/{{SERVICE}}/ChangeLog.md
    • A snippet outlining the change(s) made in the PR should be written under the ## Upcoming Release header in the past tense. Add changelog in description section if PR goes into generation branch.
    • Should not change ChangeLog.md if no new release is required, such as fixing test case only.
  • SHOULD have approved design review for the changes in this repository (Microsoft internal only) with following situations
    • Create new module from scratch
    • Create new resource types which are not easy to conform to Azure PowerShell Design Guidelines
    • Create new resource type which name doesn't use module name as prefix
    • Have design question before implementation
  • SHOULD regenerate markdown help files if there is cmdlet API change. Instruction
  • SHOULD have proper test coverage for changes in pull request.
  • SHOULD NOT introduce breaking changes in Az minor release except preview version.
  • SHOULD NOT adjust version of module manually in pull request

The example for Enable-AzCdnCustomDomainCustomHttps calls New-AzCdnManagedHttpsParameters with TLS12 as the ProtocolType even though that is an invalid value. I'm replacing the ProtocolType value with ServerNameIndication, which is one of the two valid values (ServerNameIndication and IPBased).
@ghost ghost added the customer-reported label Nov 18, 2022
@ghost
Copy link

ghost commented Nov 18, 2022

Thank you for your contribution patchin404! We will review the pull request and get back to you soon.

@Nickcandy
Copy link
Contributor

/azp run azure-powershell - security-tools

@azure-pipelines
Copy link
Contributor

Azure Pipelines successfully started running 1 pipeline(s).

@Nickcandy Nickcandy merged commit 5fcd7d0 into Azure:main Nov 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants