Skip to content

CustomBgpIpConfigurations in gateway connections #21098

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 15 commits into from
Mar 6, 2023
Merged

CustomBgpIpConfigurations in gateway connections #21098

merged 15 commits into from
Mar 6, 2023

Conversation

Khushboo-Baheti
Copy link
Member

@Khushboo-Baheti Khushboo-Baheti commented Mar 1, 2023 •
edited
Loading

Description

Adding New Cmdlets to create PSGatewayCustomBgpIpAddressIpConfiguration.
Adding new parameter GatewayCustomBgpIpAddre to Set-AzVirtualNetworkGatewayConnection and New-AzVirtualNetworkGatewayConnection.
Adding new parameter VpnGatewayCustomBgpIpAddress to New-AzVpnSiteLinkConnection.

https://github.com/Azure/azure-powershell-cmdlet-review-pr/issues/1306

Checklist

  • SHOULD select appropriate branch. Cmdlets from Autorest.PowerShell should go to generation branch.
  • SHOULD make the title of PR clear and informative, and in the present imperative tense.
  • SHOULD update ChangeLog.md file(s) appropriately
    • For any service, the ChangeLog.md file can be found at src/{{SERVICE}}/{{SERVICE}}/ChangeLog.md
    • A snippet outlining the change(s) made in the PR should be written under the ## Upcoming Release header in the past tense. Add changelog in description section if PR goes into generation branch.
    • Should not change ChangeLog.md if no new release is required, such as fixing test case only.
  • SHOULD have approved design review for the changes in this repository (Microsoft internal only) with following situations
    • Create new module from scratch
    • Create new resource types which are not easy to conform to Azure PowerShell Design Guidelines
    • Create new resource type which name doesn't use module name as prefix
    • Have design question before implementation
  • SHOULD regenerate markdown help files if there is cmdlet API change. Instruction
  • SHOULD have proper test coverage for changes in pull request.
  • SHOULD NOT introduce breaking changes in Az minor release except preview version.
  • SHOULD NOT adjust version of module manually in pull request

@azure-client-tools-bot-prd
Copy link

Validation for PowerShell Core and Windows PowerShell Starts. Thanks for your contribution!

VeryEarly
VeryEarly reviewed Mar 2, 2023
View reviewed changes
VeryEarly
VeryEarly reviewed Mar 2, 2023
View reviewed changes
VeryEarly
VeryEarly reviewed Mar 2, 2023
View reviewed changes
VeryEarly
VeryEarly reviewed Mar 2, 2023
View reviewed changes
...Network/Network/VirtualNetworkGatewayConnection/VirtualNetworkGatewayConnectionBaseCmdlet.cs
@@ -61,7 +61,7 @@ public PSVirtualNetworkGatewayConnection GetVirtualNetworkGatewayConnection(stri
return psVirtualNetworkGatewayConnection;
}

public PSVirtualNetworkGatewayConnection ToPsVirtualNetworkGatewayConnection(VirtualNetworkGatewayConnection vnetGatewayConnection)
public PSVirtualNetworkGatewayConnection ToPsVirtualNetworkGatewayConnection(Management.Network.Models.VirtualNetworkGatewayConnection vnetGatewayConnection)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same as GetAzureVirtualNetworkGatewayConnectionCommand.cs

VeryEarly
VeryEarly requested changes Mar 2, 2023
View reviewed changes
Copy link
Collaborator

@VeryEarly VeryEarly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please see comments

VeryEarly
VeryEarly reviewed Mar 2, 2023
View reviewed changes
src/Network/Network/Cortex/VpnConnection/NewAzVpnSiteLinkConnectionCommand.cs Outdated
ValueFromPipelineByPropertyName = true,
HelpMessage = "The GatewayCustomBgpIpAddress of Vpngateway used in this link connection.")]
[ValidateNotNullOrEmpty]
public PSGatewayCustomBgpIpConfiguration[] VpnGatewayCustomBgpAddresses { get; set; }
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
public PSGatewayCustomBgpIpConfiguration[] VpnGatewayCustomBgpAddresses { get; set; }
public PSGatewayCustomBgpIpConfiguration[] VpnGatewayCustomBgpAddress { get; set; }

@VeryEarly
Copy link
Collaborator

please find analyze-netcore3.1 -> staticAnalysisResults -> ExampleIssues.csv in
https://dev.azure.com/azclitools/public/_build/results?buildId=38863&view=artifacts&pathAsName=false&type=publishedArtifacts
and fix examples.

@Khushboo-Baheti
Copy link
Member Author

please find analyze-netcore3.1 -> staticAnalysisResults -> ExampleIssues.csv in https://dev.azure.com/azclitools/public/_build/results?buildId=38863&view=artifacts&pathAsName=false&type=publishedArtifacts and fix examples.

Not able to find anything here

@VeryEarly
Copy link
Collaborator

/azp run

@azure-pipelines
Copy link
Contributor

Azure Pipelines successfully started running 3 pipeline(s).

@VeryEarly VeryEarly merged commit 2d048b2 into Azure:release-network-2022-09-01 Mar 6, 2023
VeryEarly added a commit that referenced this pull request Mar 10, 2023
@VeryEarly @Satya-anshu
@isra-fel @nimaller @utbarn-ms @tejasshah7 @Khushboo-Baheti
network-2022-09-01 (#21167)
568533d 
* Created a new feature FlushConnection for Network Security Groups. (#20604)

* Updated Help files

* Added tests to PS cmdlet

* Updated to SwitchParameter as per design guidelines

* Updated changelog

* Added FlushConnection property to NSG + updated help files

* Updated changelog.md

* Updated changelog.md

* Update src/Network/Network/NetworkSecurityGroup/NewAzureNetworkSecurityGroupCommand.cs

Co-authored-by: Yeming Liu <11371776+isra-fel@users.noreply.github.com>

* Update src/Network/Network/help/New-AzNetworkSecurityGroup.md

Co-authored-by: Yeming Liu <11371776+isra-fel@users.noreply.github.com>

* Fixed indentation: Used space instead of tabs

---------

Co-authored-by: Yeming Liu <11371776+isra-fel@users.noreply.github.com>

* Add Optional Parameter "Billing Type" to Express Route Direct (#20663)

* changes

* Update ChangeLog.md

---------

Co-authored-by: Yeming Liu <11371776+isra-fel@users.noreply.github.com>

* adding circuit auth status property (#20791)

* adding auth status property

* updating change log

---------

Co-authored-by: Yeming Liu <11371776+isra-fel@users.noreply.github.com>

* Changes to add support for state in WAF Custom Rule (#21058)

* Changes to add support for state in WAF Custom Rule

* PR Review comments

* CustomBgpIpConfigurations in gateway connections (#21098)

* commit1

* fixes1

* commit2Tested

* help

* tests

* TestRecord

* fixing help

* helpfix2

* fixing help3

* FixHelp5

* fixing comments

* removelocalbuildissue

* Revert "removelocalbuildissue"

This reverts commit 9ab2e13.

* fixing build issues

---------

Co-authored-by: Khushboo Baheti <khbaheti@microsoft.com>

* Resetvpngateway with IpconfigurationId (#21142)

* commit1

* commit2

* adding tests

* fixing Test

---------

Co-authored-by: Khushboo Baheti <khbaheti@microsoft.com>

---------

Co-authored-by: Satya-anshu <70507845+Satya-anshu@users.noreply.github.com>
Co-authored-by: Yeming Liu <11371776+isra-fel@users.noreply.github.com>
Co-authored-by: nimaller <71352534+nimaller@users.noreply.github.com>
Co-authored-by: utbarn-ms <66377251+utbarn-ms@users.noreply.github.com>
Co-authored-by: tejasshah7 <49326906+tejasshah7@users.noreply.github.com>
Co-authored-by: Khushboo Baheti <37917868+Khushboo-Baheti@users.noreply.github.com>
Co-authored-by: Khushboo Baheti <khbaheti@microsoft.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@VeryEarly VeryEarly VeryEarly approved these changes

@MikhailTryakhov MikhailTryakhov Awaiting requested review from MikhailTryakhov

Assignees

@VeryEarly VeryEarly

Labels
needs-review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Khushboo-Baheti @VeryEarly @isra-fel