Skip to content

Conversation

Aman-Jain-14
Copy link
Member

…SM Jobs

Description

This PR adds support for Import, AutoExport and AutoImport HSM features for Avere Azure Storage Cache. The stable Swagger has been merged in.

Mandatory Checklist

  • SHOULD update ChangeLog.md file(s) appropriately
    • Update src/{{SERVICE}}/{{SERVICE}}/ChangeLog.md.
      • A snippet outlining the change(s) made in the PR should be written under the ## Upcoming Release header in the past tense.
    • Should not change ChangeLog.md if no new release is required, such as fixing test case only.
  • SHOULD regenerate markdown help files if there is cmdlet API change. Instruction
  • SHOULD have proper test coverage for changes in pull request.
  • SHOULD NOT adjust version of module manually in pull request

@Copilot Copilot AI review requested due to automatic review settings September 6, 2025 02:09
Copy link

Thanks for your contribution! The pull request validation has started. Please revisit this comment for updated status.

Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds support for Import, AutoExport and AutoImport HSM (Hierarchical Storage Management) features for Azure Storage Cache by updating the stable Swagger to include new job management capabilities for AML file systems.

  • Addition of new cmdlets for managing Import, AutoExport, and AutoImport jobs
  • Enhanced AML file system creation with new root squash settings and import prefix options
  • Updated module manifest and documentation to reflect the expanded functionality

Reviewed Changes

Copilot reviewed 153 out of 186 changed files in this pull request and generated 4 comments.

Show a summary per file
File Description
help/New-AzStorageCacheAmlFileSystem.md Updated with new root squash parameters and import prefix options
help/*.md (multiple new files) Added documentation for new cmdlets supporting job management operations
help/Az.StorageCache.md Updated module index with comprehensive list of new cmdlets
Az.StorageCache.psd1 Expanded exported functions list and updated module dependencies
StorageCache.sln Updated project GUID reference
test files Added new test files for import/export job functionality

Comment on lines +51 to +66
### Example 1: {{ Add title here }}
```powershell
{{ Add code here }}
```

```output
{{ Add output here (remove the output block if the example doesn't have an output) }}
```

{{ Add description here }}

### Example 2: {{ Add title here }}
```powershell
{{ Add code here }}
```

Copy link
Preview

Copilot AI Sep 6, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The example section contains placeholder text that should be replaced with actual usage examples for the Invoke-AzStorageCacheSpaceCachAllocation cmdlet.

Suggested change
### Example 1: {{ Add title here }}
```powershell
{{ Add code here }}
```
```output
{{ Add output here (remove the output block if the example doesn't have an output) }}
```
{{ Add description here }}
### Example 2: {{ Add title here }}
```powershell
{{ Add code here }}
```
### Example 1: Allocate space to a storage target in a cache
```powershell
$spaceAllocation = @(
@{
Name = "storageTarget1"
SpaceAllocationGiB = 500
}
)
Invoke-AzStorageCacheSpaceCachAllocation `
-CacheName "myCache" `
-ResourceGroupName "myResourceGroup" `
-SpaceAllocation $spaceAllocation

This example allocates 500 GiB of cache space to the storage target named "storageTarget1" in the cache "myCache" within the resource group "myResourceGroup".

Example 2: Allocate space using a JSON file

Invoke-AzStorageCacheSpaceCachAllocation `
    -CacheName "myCache" `
    -ResourceGroupName "myResourceGroup" `
    -JsonFilePath "C:\spaceAllocation.json"

This example allocates cache space to storage targets as specified in the JSON file "C:\spaceAllocation.json" for the cache "myCache" in the resource group "myResourceGroup".

Copilot uses AI. Check for mistakes.

Comment on lines +25 to +45
### Example 1: {{ Add title here }}
```powershell
{{ Add code here }}
```

```output
{{ Add output here (remove the output block if the example doesn't have an output) }}
```

{{ Add description here }}

### Example 2: {{ Add title here }}
```powershell
{{ Add code here }}
```

```output
{{ Add output here (remove the output block if the example doesn't have an output) }}
```

{{ Add description here }}
Copy link
Preview

Copilot AI Sep 6, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All example sections contain placeholder text instead of actual working examples for the Get-AzStorageCacheUsageModel cmdlet.

Suggested change
### Example 1: {{ Add title here }}
```powershell
{{ Add code here }}
```
```output
{{ Add output here (remove the output block if the example doesn't have an output) }}
```
{{ Add description here }}
### Example 2: {{ Add title here }}
```powershell
{{ Add code here }}
```
```output
{{ Add output here (remove the output block if the example doesn't have an output) }}
```
{{ Add description here }}
### Example 1: Get all available cache usage models
```powershell
Get-AzStorageCacheUsageModel

Name          : CommercialStandard
DisplayName   : Commercial Standard
Description   : Standard usage model for commercial workloads.

Name          : HighPerformance
DisplayName   : High Performance
Description   : High performance usage model for demanding workloads.

This example gets all cache usage models available to the current subscription.

Example 2: Get cache usage models for a specific subscription

Get-AzStorageCacheUsageModel -SubscriptionId "00000000-0000-0000-0000-000000000000"

Name          : CommercialStandard
DisplayName   : Commercial Standard
Description   : Standard usage model for commercial workloads.

Name          : HighPerformance
DisplayName   : High Performance
Description   : High performance usage model for demanding workloads.

This example gets all cache usage models available to the specified subscription.

Copilot uses AI. Check for mistakes.

# Debug-AzStorageCacheCachInfo

## SYNOPSIS
Tells a cache to write generate debug info for support to process.
Copy link
Preview

Copilot AI Sep 6, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Grammar error in synopsis. Should be 'Tells a cache to generate debug info for support to process.' (remove 'write' or change to 'write and generate').

Copilot uses AI. Check for mistakes.

```

## DESCRIPTION
Tells a cache to write generate debug info for support to process.
Copy link
Preview

Copilot AI Sep 6, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same grammar error repeated in description. Should be 'Tells a cache to generate debug info for support to process.'

Copilot uses AI. Check for mistakes.

@isra-fel
Copy link
Member

isra-fel commented Sep 6, 2025

/azp run

Copy link
Contributor

Azure Pipelines successfully started running 3 pipeline(s).

@isra-fel
Copy link
Member

isra-fel commented Sep 6, 2025

/azp run

Copy link
Contributor

Azure Pipelines successfully started running 3 pipeline(s).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants