[StorageCache] Adding support for Import, AutoExport and AutoImport HSM Jobs #28523
Conversation
…ort_autoimport' of https://github.com/Aman-Jain-14/azure-powershell-storagecache into dev/amajai/main-storagecache_support_for_import_autoexport_autoimport
| Thanks for your contribution! The pull request validation has started. Please revisit this comment for updated status. |
Aman-Jain-14
deleted the
dev/amajai/main-storagecache_support_for_import_autoexport_autoimport
branch
There was a problem hiding this comment.
Pull Request Overview
This pull request adds support for Import, AutoExport and AutoImport HSM Jobs to the StorageCache module, significantly expanding the functionality for managing Azure Machine Learning (AML) file systems and caching operations.
Key Changes
- Introduces comprehensive job management capabilities for Import, AutoExport, and AutoImport operations
- Adds new cmdlets for creating, retrieving, updating, and removing HSM jobs
- Extends the New-AzStorageCacheAmlFileSystem cmdlet with new root squash settings and import prefix parameters
Reviewed Changes
Copilot reviewed 153 out of 186 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| Az.StorageCache.psd1 | Updated module manifest with new function exports and dependency version |
| Az.StorageCache.md | Added documentation for all new HSM job management cmdlets |
| New-AzStorageCacheAmlFileSystem.md | Enhanced with new root squash and import prefix parameters |
| StorageCache.sln | Updated project reference GUID |
| Multiple test files | Added comprehensive test coverage for new cmdlets |
| Multiple help files | Documentation for new Get/Clear/Debug/Invoke cmdlets |
| . ($mockingPath | Select-Object -First 1).FullName | ||
| } | ||
|
|
||
| New-AzStorageCacheAutoImportJob -AmlFilesystemName 'acctest43511' -Name 'sampleAutoImportJob' -ResourceGroupName 'acctest43511' -Location 'Canada Central' -AutoImportPrefix @('/path1', '/path2') |
There was a problem hiding this comment.
The test file contains hardcoded values for resource names and subscription IDs that should be parameterized or use environment variables for better test portability and security.
Copilot uses AI. Check for mistakes.
| . ($mockingPath | Select-Object -First 1).FullName | ||
| } | ||
|
|
||
| New-AzStorageCacheAutoExportJob -AmlFilesystemName 'acctest43511' -Name 'sampleUpdateJob' -ResourceGroupName 'acctest43511' -Location 'Canada Central' -AutoExportPrefix @('/path1') |
There was a problem hiding this comment.
Similar to the AutoImportJob test, this file contains hardcoded resource names and subscription IDs that should be parameterized for better test maintainability.
Copilot uses AI. Check for mistakes.
| ### Example 1: {{ Add title here }} | ||
| ```powershell | ||
| {{ Add code here }} | ||
| ``` | ||
|
|
||
| ```output | ||
| {{ Add output here (remove the output block if the example doesn't have an output) }} | ||
| ``` | ||
|
|
||
| {{ Add description here }} | ||
|
|
There was a problem hiding this comment.
The help file contains placeholder text for examples that should be replaced with actual working examples to provide meaningful documentation for users.
| ### Example 1: {{ Add title here }} | |
| ```powershell | |
| {{ Add code here }} | |
| ``` | |
| ```output | |
| {{ Add output here (remove the output block if the example doesn't have an output) }} | |
| ``` | |
| {{ Add description here }} | |
| ### Example 1: Allocate space to a storage target in a cache | |
| ```powershell | |
| $spaceAllocation = @( | |
| @{ | |
| Name = "storagetarget1" | |
| Size = 1000 | |
| } | |
| ) | |
| Invoke-AzStorageCacheSpaceCachAllocation -CacheName "myCache" -ResourceGroupName "myResourceGroup" -SpaceAllocation $spaceAllocation |
This example allocates 1000 units of space to the storage target named "storagetarget1" in the cache "myCache" within the resource group "myResourceGroup".
Copilot uses AI. Check for mistakes.
Description
Adding support for Import, AutoExport and AutoImport HSM Jobs
Mandatory Checklist
Please choose the target release of Azure PowerShell. (⚠️ Target release is a different concept from API readiness. Please click below links for details.)
[Y] Check this box to confirm: I have read the Submitting Changes section of
CONTRIBUTING.mdand reviewed the following information:ChangeLog.mdfile(s) appropriatelysrc/{{SERVICE}}/{{SERVICE}}/ChangeLog.md.## Upcoming Releaseheader in the past tense.ChangeLog.mdif no new release is required, such as fixing test case only.