Skip to content

Conversation

yifanz7
Copy link
Member

@yifanz7 yifanz7 commented Sep 18, 2025

Description

Mandatory Checklist

  • SHOULD update ChangeLog.md file(s) appropriately
    • Update src/{{SERVICE}}/{{SERVICE}}/ChangeLog.md.
      • A snippet outlining the change(s) made in the PR should be written under the ## Upcoming Release header in the past tense.
    • Should not change ChangeLog.md if no new release is required, such as fixing test case only.
  • SHOULD regenerate markdown help files if there is cmdlet API change. Instruction
  • SHOULD have proper test coverage for changes in pull request.
  • SHOULD NOT adjust version of module manually in pull request

@Copilot Copilot AI review requested due to automatic review settings September 18, 2025 04:26
Copy link

Thanks for your contribution! The pull request validation has started. Please revisit this comment for updated status.

Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds a new Get-AzStorageSku cmdlet to the Azure Storage PowerShell module that lists available SKUs supported by Microsoft.Storage for a given subscription.

  • Introduces a new AutoRest-generated cmdlet for retrieving storage SKUs
  • Updates module dependencies and documentation
  • Refactors some parameter names in existing cmdlets for consistency

Reviewed Changes

Copilot reviewed 25 out of 25 changed files in this pull request and generated 3 comments.

Show a summary per file
File Description
src/Storage/Storage.sln Updates project GUID for AutoRest Storage project
src/Storage/Storage.Management/Az.Storage.psd1 Adds new Get-AzStorageSku function and updates required module version
src/Storage/Storage.Management/help/*.md Updates help documentation with new cmdlet and fixes line wrapping issues
src/Storage/Storage.Autorest/test/Get-AzStorageSku.Tests.ps1 Adds basic test coverage for the new Get-AzStorageSku cmdlet
src/Storage/Storage.Autorest/README.md Updates API version references and removes Sku subject from exclusions
src/Storage/Storage.Autorest/Properties/AssemblyInfo.cs Increments assembly version from 9.0.0 to 9.1.0

```

### DirectoryObject
### DirecotryObject
Copy link
Preview

Copilot AI Sep 18, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Parameter set name 'DirecotryObject' contains a spelling error. It should be 'DirectoryObject'.

Suggested change
### DirecotryObject
### DirectoryObject

Copilot uses AI. Check for mistakes.

```

### DirectoryObject
### DirecotryObject
Copy link
Preview

Copilot AI Sep 18, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Parameter set name 'DirecotryObject' contains a spelling error. It should be 'DirectoryObject'.

Suggested change
### DirecotryObject
### DirectoryObject

Copilot uses AI. Check for mistakes.

Comment on lines 1125 to 830
## PARAMETERS
### -DefaultProfile
The credentials, account, tenant, and subscription used for communication with Azure.
Copy link
Preview

Copilot AI Sep 18, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PARAMETERS section appears to be duplicated entirely in this help file. Remove the duplicate content from lines 1274-1420 to avoid redundancy and maintain clean documentation.

Copilot uses AI. Check for mistakes.

@yifanz7 yifanz7 marked this pull request as draft September 18, 2025 06:30
@yifanz7 yifanz7 marked this pull request as ready for review September 18, 2025 07:09
@VeryEarly VeryEarly self-assigned this Sep 18, 2025
@VeryEarly VeryEarly merged commit aee368c into Azure:main Sep 18, 2025
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants