Skip to content

Conversation

VeryEarly
Copy link
Collaborator

Description

Mandatory Checklist

  • SHOULD update ChangeLog.md file(s) appropriately
    • Update src/{{SERVICE}}/{{SERVICE}}/ChangeLog.md.
      • A snippet outlining the change(s) made in the PR should be written under the ## Upcoming Release header in the past tense.
    • Should not change ChangeLog.md if no new release is required, such as fixing test case only.
  • SHOULD regenerate markdown help files if there is cmdlet API change. Instruction
  • SHOULD have proper test coverage for changes in pull request.
  • SHOULD NOT adjust version of module manually in pull request

@Copilot Copilot AI review requested due to automatic review settings September 22, 2025 09:13
Copy link

Thanks for your contribution! The pull request validation has started. Please revisit this comment for updated status.

Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Promotes Az.DataMigration module to GA and integrates it into the Az rollup module.

  • Added Az.DataMigration to minimal version tracking and Az meta module dependency list.
  • Updated ChangeLog with GA announcement and related feature notes.

Reviewed Changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.

File Description
tools/VersionController/MinimalVersion.csv Registers Az.DataMigration with minimal version 1.0.0 for GA.
tools/Az/Az.psd1 Adds Az.DataMigration to Az meta module dependencies (version inconsistency noted).
src/DataMigration/DataMigration/ChangeLog.md Announces GA and documents related updates (tense/style issue).

@{ModuleName = 'Az.DataFactory'; RequiredVersion = '1.19.4'; },
@{ModuleName = 'Az.DataLakeAnalytics'; RequiredVersion = '1.1.0'; },
@{ModuleName = 'Az.DataLakeStore'; RequiredVersion = '1.5.0'; },
@{ModuleName = 'Az.DataMigration'; RequiredVersion = '0.15.0'; },
Copy link
Preview

Copilot AI Sep 22, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

RequiredVersion is set to 0.15.0 while MinimalVersion.csv declares Az.DataMigration at 1.0.0 and the ChangeLog announces GA. This will cause the Az rollup to pull a pre-GA version. Update RequiredVersion to '1.0.0' to align with the GA promotion.

Suggested change
@{ModuleName = 'Az.DataMigration'; RequiredVersion = '0.15.0'; },
@{ModuleName = 'Az.DataMigration'; RequiredVersion = '1.0.0'; },

Copilot uses AI. Check for mistakes.

- Additional information about change #1
-->
## Upcoming Release
* General availability for module Az.DataMigration
Copy link
Preview

Copilot AI Sep 22, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ChangeLog entries under Upcoming Release should use past tense per repository guidelines. Suggested revision: "* Made module Az.DataMigration generally available." or "* Module Az.DataMigration reached general availability."

Suggested change
* General availability for module Az.DataMigration
* Made module Az.DataMigration generally available.

Copilot uses AI. Check for mistakes.

@VeryEarly VeryEarly merged commit 49fa502 into main Sep 23, 2025
12 checks passed
@VeryEarly VeryEarly deleted the yabo/GA-DataMigration branch September 23, 2025 01:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants