-
Notifications
You must be signed in to change notification settings - Fork 4.1k
GA Az.DataMigration #28598
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GA Az.DataMigration #28598
Conversation
Thanks for your contribution! The pull request validation has started. Please revisit this comment for updated status. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
Promotes Az.DataMigration module to GA and integrates it into the Az rollup module.
- Added Az.DataMigration to minimal version tracking and Az meta module dependency list.
- Updated ChangeLog with GA announcement and related feature notes.
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
File | Description |
---|---|
tools/VersionController/MinimalVersion.csv | Registers Az.DataMigration with minimal version 1.0.0 for GA. |
tools/Az/Az.psd1 | Adds Az.DataMigration to Az meta module dependencies (version inconsistency noted). |
src/DataMigration/DataMigration/ChangeLog.md | Announces GA and documents related updates (tense/style issue). |
@{ModuleName = 'Az.DataFactory'; RequiredVersion = '1.19.4'; }, | ||
@{ModuleName = 'Az.DataLakeAnalytics'; RequiredVersion = '1.1.0'; }, | ||
@{ModuleName = 'Az.DataLakeStore'; RequiredVersion = '1.5.0'; }, | ||
@{ModuleName = 'Az.DataMigration'; RequiredVersion = '0.15.0'; }, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
RequiredVersion is set to 0.15.0 while MinimalVersion.csv declares Az.DataMigration at 1.0.0 and the ChangeLog announces GA. This will cause the Az rollup to pull a pre-GA version. Update RequiredVersion to '1.0.0' to align with the GA promotion.
@{ModuleName = 'Az.DataMigration'; RequiredVersion = '0.15.0'; }, | |
@{ModuleName = 'Az.DataMigration'; RequiredVersion = '1.0.0'; }, |
Copilot uses AI. Check for mistakes.
- Additional information about change #1 | ||
--> | ||
## Upcoming Release | ||
* General availability for module Az.DataMigration |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ChangeLog entries under Upcoming Release should use past tense per repository guidelines. Suggested revision: "* Made module Az.DataMigration generally available." or "* Module Az.DataMigration reached general availability."
* General availability for module Az.DataMigration | |
* Made module Az.DataMigration generally available. |
Copilot uses AI. Check for mistakes.
Description
Mandatory Checklist
Please choose the target release of Azure PowerShell. (⚠️ Target release is a different concept from API readiness. Please click below links for details.)
Check this box to confirm: I have read the Submitting Changes section of
CONTRIBUTING.md
and reviewed the following information:ChangeLog.md
file(s) appropriatelysrc/{{SERVICE}}/{{SERVICE}}/ChangeLog.md
.## Upcoming Release
header in the past tense.ChangeLog.md
if no new release is required, such as fixing test case only.