Skip to content

Conversation

sssash18
Copy link
Member

  • Modified Update-AzStorageMoverProject recording JSON to reflect new resource group and project names.
  • Updated environment variables in env.json to match new naming conventions and resource identifiers.
  • Adjusted utility script to set the correct resource group name.
  • Changed project GUID in solution file to maintain consistency.
  • Updated Az.StorageMover module generation date in the PSD1 file.
  • Enhanced help documentation for New-AzStorageMoverAzStorageContainerEndpoint and New-AzStorageMoverMultiCloudConnectorEndpoint with identity details.
  • Corrected online version link for Update-AzStorageMoverAzNfsFileShareEndpoint help documentation.
  • Added identity information to the output properties in help documentation for storage container and multi-cloud connector endpoints.

Description

Mandatory Checklist

  • SHOULD update ChangeLog.md file(s) appropriately
    • Update src/{{SERVICE}}/{{SERVICE}}/ChangeLog.md.
      • A snippet outlining the change(s) made in the PR should be written under the ## Upcoming Release header in the past tense.
    • Should not change ChangeLog.md if no new release is required, such as fixing test case only.
  • SHOULD regenerate markdown help files if there is cmdlet API change. Instruction
  • SHOULD have proper test coverage for changes in pull request.
  • SHOULD NOT adjust version of module manually in pull request

- Modified Update-AzStorageMoverProject recording JSON to reflect new resource group and project names.
- Updated environment variables in env.json to match new naming conventions and resource identifiers.
- Adjusted utility script to set the correct resource group name.
- Changed project GUID in solution file to maintain consistency.
- Updated Az.StorageMover module generation date in the PSD1 file.
- Enhanced help documentation for New-AzStorageMoverAzStorageContainerEndpoint and New-AzStorageMoverMultiCloudConnectorEndpoint with identity details.
- Corrected online version link for Update-AzStorageMoverAzNfsFileShareEndpoint help documentation.
- Added identity information to the output properties in help documentation for storage container and multi-cloud connector endpoints.
@Copilot Copilot AI review requested due to automatic review settings September 23, 2025 06:28
Copy link

Thanks for your contribution! The pull request validation has started. Please revisit this comment for updated status.

Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates StorageMover project configurations and test recordings to reflect new resource group and naming conventions, along with enhanced help documentation for specific endpoints.

  • Updates test recordings and environment variables with new resource group name (choudharysutest) and random string identifier (o7je935h)
  • Enhances help documentation with identity information for storage container and multi-cloud connector endpoints
  • Corrects online help link for Azure NFS file share endpoint documentation

Reviewed Changes

Copilot reviewed 45 out of 47 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
Update-AzStorageMoverAzStorageContainerEndpoint.md Adds identity properties to help documentation output
Update-AzStorageMoverAzNfsFileShareEndpoint.md Fixes online version link URL
New-AzStorageMoverMultiCloudConnectorEndpoint.md Removes identity line from help documentation
New-AzStorageMoverAzStorageContainerEndpoint.md Adds identity properties to help documentation output
Az.StorageMover.psd1 Updates module generation date
StorageMover.sln Changes project GUID
utils.ps1 Updates resource group name in test utility
env.json Updates environment variables with new naming conventions
Multiple test recording files Updates recorded API responses with new resource group and identifier names

@isra-fel
Copy link
Member

/azp run

Copy link
Contributor

Azure Pipelines successfully started running 3 pipeline(s).

…ileShareEndpoint.md

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
@isra-fel
Copy link
Member

/azp run

Copy link
Contributor

Azure Pipelines successfully started running 3 pipeline(s).

@sssash18 sssash18 added this to the Az 14.5.0 (10/14/2025) milestone Sep 25, 2025
@VeryEarly VeryEarly self-assigned this Sep 25, 2025

$Properties.EndpointType = "AzureMultiCloudConnector"
$PSBoundParameters.Add("Property", $Properties)

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is the default value returned from server "SystemAssigned"? If not this could be a possible breaking chang

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually the original PR for this new api version is not released yet, this is just a fix PR in succession to that.:
#28488

So should not cause any issue.

Copy link
Collaborator

@VeryEarly VeryEarly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@isra-fel
Copy link
Member

/azp run

Copy link
Contributor

Azure Pipelines successfully started running 3 pipeline(s).

@sssash18 sssash18 requested a review from VeryEarly September 25, 2025 08:46
@VeryEarly VeryEarly merged commit f218c98 into Azure:main Sep 26, 2025
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants