-
Notifications
You must be signed in to change notification settings - Fork 4.1k
Update StorageMover project configurations and test recordings #28603
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update StorageMover project configurations and test recordings #28603
Conversation
- Modified Update-AzStorageMoverProject recording JSON to reflect new resource group and project names. - Updated environment variables in env.json to match new naming conventions and resource identifiers. - Adjusted utility script to set the correct resource group name. - Changed project GUID in solution file to maintain consistency. - Updated Az.StorageMover module generation date in the PSD1 file. - Enhanced help documentation for New-AzStorageMoverAzStorageContainerEndpoint and New-AzStorageMoverMultiCloudConnectorEndpoint with identity details. - Corrected online version link for Update-AzStorageMoverAzNfsFileShareEndpoint help documentation. - Added identity information to the output properties in help documentation for storage container and multi-cloud connector endpoints.
Thanks for your contribution! The pull request validation has started. Please revisit this comment for updated status. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR updates StorageMover project configurations and test recordings to reflect new resource group and naming conventions, along with enhanced help documentation for specific endpoints.
- Updates test recordings and environment variables with new resource group name (
choudharysutest
) and random string identifier (o7je935h
) - Enhances help documentation with identity information for storage container and multi-cloud connector endpoints
- Corrects online help link for Azure NFS file share endpoint documentation
Reviewed Changes
Copilot reviewed 45 out of 47 changed files in this pull request and generated 1 comment.
Show a summary per file
File | Description |
---|---|
Update-AzStorageMoverAzStorageContainerEndpoint.md |
Adds identity properties to help documentation output |
Update-AzStorageMoverAzNfsFileShareEndpoint.md |
Fixes online version link URL |
New-AzStorageMoverMultiCloudConnectorEndpoint.md |
Removes identity line from help documentation |
New-AzStorageMoverAzStorageContainerEndpoint.md |
Adds identity properties to help documentation output |
Az.StorageMover.psd1 |
Updates module generation date |
StorageMover.sln |
Changes project GUID |
utils.ps1 |
Updates resource group name in test utility |
env.json |
Updates environment variables with new naming conventions |
Multiple test recording files | Updates recorded API responses with new resource group and identifier names |
src/StorageMover/StorageMover/help/Update-AzStorageMoverAzNfsFileShareEndpoint.md
Outdated
Show resolved
Hide resolved
/azp run |
Azure Pipelines successfully started running 3 pipeline(s). |
…ileShareEndpoint.md Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
/azp run |
Azure Pipelines successfully started running 3 pipeline(s). |
|
||
$Properties.EndpointType = "AzureMultiCloudConnector" | ||
$PSBoundParameters.Add("Property", $Properties) | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is the default value returned from server "SystemAssigned"? If not this could be a possible breaking chang
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actually the original PR for this new api version is not released yet, this is just a fix PR in succession to that.:
#28488
So should not cause any issue.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please update https://github.com/sssash18/azure-powershell/blob/choudharysu/fix_new_api_version/src/StorageMover/StorageMover/ChangeLog.md
Simply copy the PR description you have.
/azp run |
Azure Pipelines successfully started running 3 pipeline(s). |
Description
Mandatory Checklist
Please choose the target release of Azure PowerShell. (⚠️ Target release is a different concept from API readiness. Please click below links for details.)
Check this box to confirm: I have read the Submitting Changes section of
CONTRIBUTING.md
and reviewed the following information:ChangeLog.md
file(s) appropriatelysrc/{{SERVICE}}/{{SERVICE}}/ChangeLog.md
.## Upcoming Release
header in the past tense.ChangeLog.md
if no new release is required, such as fixing test case only.