Bug Fix: Buse boolean in comparision #28653
Conversation
| Thanks for your contribution! The pull request validation has started. Please revisit this comment for updated status. |
There was a problem hiding this comment.
Pull Request Overview
This PR fixes a bug in PowerShell boolean comparisons by explicitly comparing boolean values with $true instead of relying on implicit boolean evaluation.
Changes Made:
- Replaced direct function calls in if statements with explicit boolean variable assignments and comparisons
- Applied consistent formatting for boolean condition checks
| if (Test-ComputerNameHasDnsSuffix -ComputerName $ComputerName) | ||
| $computerNameHasDNSSuffix = Test-ComputerNameHasDnsSuffix -ComputerName $ComputerName | ||
|
|
||
| if ($computerNameHasDNSSuffix -eq $true) |
There was a problem hiding this comment.
Explicit comparison with $true is unnecessary in PowerShell. The variable $computerNameHasDNSSuffix can be used directly in the if statement: if ($computerNameHasDNSSuffix). This is more idiomatic PowerShell and achieves the same result.
| if ($computerNameHasDNSSuffix -eq $true) | |
| if ($computerNameHasDNSSuffix) |
Copilot uses AI. Check for mistakes.
| if (Test-ComputerNameHasDnsSuffix -ComputerName $ComputerName) | ||
| $computerNameHasDNSSuffix = Test-ComputerNameHasDnsSuffix -ComputerName $ComputerName | ||
|
|
||
| if ($computerNameHasDNSSuffix -eq $true) |
There was a problem hiding this comment.
Explicit comparison with $true is unnecessary in PowerShell. The variable $computerNameHasDNSSuffix can be used directly in the if statement: if ($computerNameHasDNSSuffix). This is more idiomatic PowerShell and achieves the same result.
| if ($computerNameHasDNSSuffix -eq $true) | |
| if ($computerNameHasDNSSuffix) |
Copilot uses AI. Check for mistakes.
| { | ||
| if (Test-ComputerNameHasDnsSuffix -ComputerName $ComputerName) | ||
| $computerNameHasDNSSuffix = Test-ComputerNameHasDnsSuffix -ComputerName $ComputerName | ||
|
|
There was a problem hiding this comment.
Inconsistent indentation: this line has extra whitespace that doesn't match the surrounding code formatting.
Copilot uses AI. Check for mistakes.
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
shuklaprakhar415
modified the milestones:
Az 14.6.0 (11/04/2025),
Az 14.5.0 (10/14/2025)
3 participants
Description
Mandatory Checklist
Please choose the target release of Azure PowerShell. (⚠️ Target release is a different concept from API readiness. Please click below links for details.)
Check this box to confirm: I have read the Submitting Changes section of
CONTRIBUTING.mdand reviewed the following information:ChangeLog.mdfile(s) appropriatelysrc/{{SERVICE}}/{{SERVICE}}/ChangeLog.md.## Upcoming Releaseheader in the past tense.ChangeLog.mdif no new release is required, such as fixing test case only.