Fixed #5536, fixed a test deadlock discovered while testing the fix for 5536, added some diagnostics for uAMQP to help track the problem.

[LarryOsterman]

Pull Request Checklist

Please leverage this checklist as a reminder to address commonly occurring feedback when submitting a pull request to make sure your PR can be reviewed quickly:

See the detailed list in the contributing guide.

• C++ Guidelines
• Doxygen docs
• Unit tests
• No unwanted commits/changes
• Descriptive title/description
  • PR is single purpose
  • Related issue listed
• Comments in source
• No typos
• Update changelog
• Not work-in-progress
• External references or docs updated
• Self review of PR done
• Any breaking changes?

[antkmsft]

Thank you! I'm glad to see this fixed. It must not have been easy to repro this.

Add changelog?

BTW, for automatic issue linking and integration, I think you need to put Fixes #5536 in the PR description, not to the title.

[ahsonkhan]

This PR is doing a few things. For my edification, either in the PR description, or as a reply, can you please summarize the root cause of the underlying issue, and highlight how this PR is fixing it? It would be helpful in reviewing the most relevant parts.

[LarryOsterman]

This PR is doing a few things. For my edification, either in the PR description, or as a reply, can you please summarize the root cause of the underlying issue, and highlight how this PR is fixing it? It would be helpful in reviewing the most relevant parts.

IMHO the PR is doing one thing: Making the link test reliable. And most of the root causes are laid out in the text of the PR.

But here's a summary of the fixes:

• Fixed a use-after-free error caused by unprotected access to a uAMQP API, specifically the link_create and link_create_from_endpoint APIs.
• Fixed a deadlock caused by calling AddPollable while holding the connection lock.
• Fixed a case in uAMQP where functions were called on a link before setting the value of the name field
• Fixed an uninitialized member field in uAMQP, which could lead to freeing uninitialized memory.
• Fixed a bug in uAMQP where the session_set_link_endpoint_callback method was not called from link_create_from_endpoint.

All these fixes were found either when running the test lots of times, or by diagnostics added trying to track down the bugs.