Cosmos DB - availability strategy fix with query #36786
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Updated read hang grace and cancellation count threshold * Updated CHANGELOG.md * Updated CHANGELOG.md * Updated CHANGELOG.md
* Updated release versions to 4.48.1 for azure-cosmos * Updated release notes
…ilabilityStrategy is enabled.
…abianm/AvailabilityStrategyAllRegionExceptionFix
…ithub.com/Azure/azure-sdk-for-java into users/fabianm/AvailabilityStrategyAllRegionExceptionFix
…' of https://github.com/FabianMeiswinkel/azure-sdk-for-java into users/fabianm/AvailabilityStrategyAllRegionExceptionFix
…6479) * Refactoring the AvailabilityStrategyNoSuchElementFix * Reacting to code review comments
…ithub.com/Azure/azure-sdk-for-java into users/fabianm/AvailabilityStrategyAllRegionExceptionFix
…to users/fabianm/AvailabilityStrategyAllRegionExceptionFix
…to users/fabianm/AvailabilityStrategyAllRegionExceptionFix
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run java - cosmos - tests |
|
/azp run java - cosmos - spark |
|
Azure Pipelines successfully started running 1 pipeline(s). |
1 similar comment
|
Azure Pipelines successfully started running 1 pipeline(s). |
…to users/fabianm/AvailabilityStrategyFixWithQuery
|
/azp run java - cosmos - tests |
|
/azp run java - cosmos - spark |
|
Azure Pipelines successfully started running 1 pipeline(s). |
1 similar comment
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run java - cosmos - tests |
|
/azp run java - cosmos - spark |
|
Azure Pipelines successfully started running 1 pipeline(s). |
1 similar comment
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run java - cosmos - spark |
|
/azp run java - cosmos - tests |
|
Azure Pipelines successfully started running 1 pipeline(s). |
1 similar comment
|
Azure Pipelines successfully started running 1 pipeline(s). |
xinlian12
reviewed
Sep 29, 2023
sdk/cosmos/azure-cosmos-spark_3_2-12/src/main/scala/com/azure/cosmos/SparkBridgeInternal.scala
Show resolved
Hide resolved
xinlian12
reviewed
Sep 29, 2023
sdk/cosmos/azure-cosmos-tests/src/test/java/com/azure/cosmos/ClientMetricsTest.java
Show resolved
Hide resolved
xinlian12
reviewed
Sep 29, 2023
sdk/cosmos/azure-cosmos-tests/src/test/java/com/azure/cosmos/TracerUnderTest.java
Show resolved
Hide resolved
xinlian12
reviewed
Sep 29, 2023
sdk/cosmos/azure-cosmos/src/main/java/com/azure/cosmos/CosmosAsyncContainer.java
Show resolved
Hide resolved
xinlian12
reviewed
Sep 29, 2023
sdk/cosmos/azure-cosmos/src/main/java/com/azure/cosmos/implementation/FeedOperationState.java
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds option to do hedging via availability strategy not just for point operations but also query operations.
When adding test coverage for this feature a few issues with regards to diagnostics in queries have been identified and also fixed in this PR:
CosmosPagedFluxwas always captured in a single CosmosDiagnosticsContext instance / and a single tracing span. The guiding principle is that there should be one ComsosDiagnosticsContext and trace span per user operation in the SDK. For queries it is not super clear whether you should treat creating a query and full draining it as a single user interaction or whether processing each page returned from theCosmosPagedFluxshould be treated as the user interaction. For single partition queries returning only few records it is the same - but especially for long-running queries or for queries across dozens/hundreds of partitions it makes a big difference. When having only one CosmosDiagnosticsCOntext per query it means metrics/logging etc. will only happen at the end-of the query's lifecylce - it seems preferrable to instead emit them per page to allow monitoring while the long running query is still processing as well. After some offline discussions we decided to switch to emitting CosmosDiagnosticsContext per page - and this is also included in this PR.CosmosDiagnosticsContext.getSequnceNumberwhich is only populated for feed operations - the combination ofCorrelatedActivityIdandSequenceNumberwill be able to reconstruct the order in which operations/traces etc. have happened.All SDK Contribution checklist:
General Guidelines and Best Practices
Testing Guidelines