Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

removeWinutilsDownloadStep #38030

Merged
merged 1 commit into from
Dec 12, 2023
Merged

removeWinutilsDownloadStep #38030

merged 1 commit into from
Dec 12, 2023

Conversation

xinlian12
Copy link
Member

The tests have been changed to use in-memory handoff simulator, winutils is not needed anymore.

FabianMeiswinkel
FabianMeiswinkel approved these changes Dec 12, 2023
View reviewed changes
Copy link
Member

@FabianMeiswinkel FabianMeiswinkel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@xinlian12 xinlian12 merged commit 097c182 into Azure:main Dec 12, 2023
23 checks passed
Netyyyy pushed a commit to Netyyyy/azure-sdk-for-java that referenced this pull request Dec 13, 2023
@xinlian12 @Netyyyy
remove winutils download steps (Azure#38030)
2ecc1d2 
Co-authored-by: annie-mac <xinlian@microsoft.com>
(cherry picked from commit 097c182)
Netyyyy added a commit that referenced this pull request Dec 14, 2023
@Netyyyy @xinlian12
External dependencies upgrade - Spring Boot 3.2.0 and Spring Cloud 20…
b796ac8 
…23.0.0 (#38011)

* Upgrade external dependencies to align with Spring Boot 3.2.0

* remove winutils download steps (#38030)

Co-authored-by: annie-mac <xinlian@microsoft.com>
(cherry picked from commit 097c182)

---------

Co-authored-by: github-actions <github-actions@github.com>
Co-authored-by: Annie Liang <64233642+xinlian12@users.noreply.github.com>
FabianMeiswinkel pushed a commit to FabianMeiswinkel/azure-sdk-for-java that referenced this pull request Feb 3, 2024
@xinlian12 @FabianMeiswinkel
remove winutils download steps (Azure#38030)
859b451 
Co-authored-by: annie-mac <xinlian@microsoft.com>
FabianMeiswinkel added a commit that referenced this pull request Feb 4, 2024
@FabianMeiswinkel @xinlian12
Release azure-cosmos 4.53.2-hotfix (#38614)
c4bb33c 
* Few minor diagnostics perf improvements (#38232)

* Check for actual meterRegistry

* Update ClientTelemetryMetrics.java

* Update ClientTelemetryMetrics.java

* Update CosmosDiagnosticsTest.java

* Removing String.format in metrics

* Update ClientTelemetryMetrics.java

* Update Uri.java

* Update RntbdClientChannelHealthChecker.java

* Update RntbdToken.java

* Update FaultInjectionRequestContext.java

* Update RntbdTokenStream.java

* Update RntbdTokenStream.java

* Update RntbdTokenStream.java

* EnumMap changes

* Avoiding ImmutableEnumMaps

* Fixing unit tests

* Update ClientTelemetryMetrics.java

* Update FaultInjectionRequestContext.java

* Update CHANGELOG.md

* Release preparations

* Update CHANGELOG.md

* Allowing to opt-out of E2E timeout for non-point operations via system property or environment variable (#38388)

* Allowing to opt-out of E2E timeout for non-point operations via system property or environment variable

* Tests

* Reacting to code review feedback

* remove winutils download steps (#38030)

Co-authored-by: annie-mac <xinlian@microsoft.com>

* addChannelAcquisitionContextInCosmosDiagnosticsBasedOnLatency (#38416)

* add channelAcquisitionContext in cosmosDiagnostics when reaching threshold

---------

Co-authored-by: annie-mac <xinlian@microsoft.com>

---------

Co-authored-by: Annie Liang <64233642+xinlian12@users.noreply.github.com>
Co-authored-by: annie-mac <xinlian@microsoft.com>
FabianMeiswinkel added a commit that referenced this pull request Feb 4, 2024
@FabianMeiswinkel @xinlian12
Fixing release build break (link verification) for hotfix (#38621)
ae39943 
* Few minor diagnostics perf improvements (#38232)

* Check for actual meterRegistry

* Update ClientTelemetryMetrics.java

* Update ClientTelemetryMetrics.java

* Update CosmosDiagnosticsTest.java

* Removing String.format in metrics

* Update ClientTelemetryMetrics.java

* Update Uri.java

* Update RntbdClientChannelHealthChecker.java

* Update RntbdToken.java

* Update FaultInjectionRequestContext.java

* Update RntbdTokenStream.java

* Update RntbdTokenStream.java

* Update RntbdTokenStream.java

* EnumMap changes

* Avoiding ImmutableEnumMaps

* Fixing unit tests

* Update ClientTelemetryMetrics.java

* Update FaultInjectionRequestContext.java

* Update CHANGELOG.md

* Release preparations

* Update CHANGELOG.md

* Allowing to opt-out of E2E timeout for non-point operations via system property or environment variable (#38388)

* Allowing to opt-out of E2E timeout for non-point operations via system property or environment variable

* Tests

* Reacting to code review feedback

* remove winutils download steps (#38030)

Co-authored-by: annie-mac <xinlian@microsoft.com>

* addChannelAcquisitionContextInCosmosDiagnosticsBasedOnLatency (#38416)

* add channelAcquisitionContext in cosmosDiagnostics when reaching threshold

---------

Co-authored-by: annie-mac <xinlian@microsoft.com>

* Fixing release break for hotfix

---------

Co-authored-by: Annie Liang <64233642+xinlian12@users.noreply.github.com>
Co-authored-by: annie-mac <xinlian@microsoft.com>
FabianMeiswinkel added a commit that referenced this pull request Feb 4, 2024
@FabianMeiswinkel @xinlian12
Disable prerelease validation to enforce beta suffix for hotfix (#38622)
69804c1 
* Few minor diagnostics perf improvements (#38232)

* Check for actual meterRegistry

* Update ClientTelemetryMetrics.java

* Update ClientTelemetryMetrics.java

* Update CosmosDiagnosticsTest.java

* Removing String.format in metrics

* Update ClientTelemetryMetrics.java

* Update Uri.java

* Update RntbdClientChannelHealthChecker.java

* Update RntbdToken.java

* Update FaultInjectionRequestContext.java

* Update RntbdTokenStream.java

* Update RntbdTokenStream.java

* Update RntbdTokenStream.java

* EnumMap changes

* Avoiding ImmutableEnumMaps

* Fixing unit tests

* Update ClientTelemetryMetrics.java

* Update FaultInjectionRequestContext.java

* Update CHANGELOG.md

* Release preparations

* Update CHANGELOG.md

* Allowing to opt-out of E2E timeout for non-point operations via system property or environment variable (#38388)

* Allowing to opt-out of E2E timeout for non-point operations via system property or environment variable

* Tests

* Reacting to code review feedback

* remove winutils download steps (#38030)

Co-authored-by: annie-mac <xinlian@microsoft.com>

* addChannelAcquisitionContextInCosmosDiagnosticsBasedOnLatency (#38416)

* add channelAcquisitionContext in cosmosDiagnostics when reaching threshold

---------

Co-authored-by: annie-mac <xinlian@microsoft.com>

* Fixing release break for hotfix

* Update utils.py

---------

Co-authored-by: Annie Liang <64233642+xinlian12@users.noreply.github.com>
Co-authored-by: annie-mac <xinlian@microsoft.com>
FabianMeiswinkel added a commit that referenced this pull request Feb 4, 2024
@FabianMeiswinkel @xinlian12
Disable release version validations (#38623)
271736e 
* Few minor diagnostics perf improvements (#38232)

* Check for actual meterRegistry

* Update ClientTelemetryMetrics.java

* Update ClientTelemetryMetrics.java

* Update CosmosDiagnosticsTest.java

* Removing String.format in metrics

* Update ClientTelemetryMetrics.java

* Update Uri.java

* Update RntbdClientChannelHealthChecker.java

* Update RntbdToken.java

* Update FaultInjectionRequestContext.java

* Update RntbdTokenStream.java

* Update RntbdTokenStream.java

* Update RntbdTokenStream.java

* EnumMap changes

* Avoiding ImmutableEnumMaps

* Fixing unit tests

* Update ClientTelemetryMetrics.java

* Update FaultInjectionRequestContext.java

* Update CHANGELOG.md

* Release preparations

* Update CHANGELOG.md

* Allowing to opt-out of E2E timeout for non-point operations via system property or environment variable (#38388)

* Allowing to opt-out of E2E timeout for non-point operations via system property or environment variable

* Tests

* Reacting to code review feedback

* remove winutils download steps (#38030)

Co-authored-by: annie-mac <xinlian@microsoft.com>

* addChannelAcquisitionContextInCosmosDiagnosticsBasedOnLatency (#38416)

* add channelAcquisitionContext in cosmosDiagnostics when reaching threshold

---------

Co-authored-by: annie-mac <xinlian@microsoft.com>

* Fixing release break for hotfix

* Update utils.py

* Update set_versions.py

---------

Co-authored-by: Annie Liang <64233642+xinlian12@users.noreply.github.com>
Co-authored-by: annie-mac <xinlian@microsoft.com>
FabianMeiswinkel added a commit that referenced this pull request Feb 4, 2024
@FabianMeiswinkel @xinlian12
Fixing utils.py (#38624)
d9ff0dc 
* Few minor diagnostics perf improvements (#38232)

* Check for actual meterRegistry

* Update ClientTelemetryMetrics.java

* Update ClientTelemetryMetrics.java

* Update CosmosDiagnosticsTest.java

* Removing String.format in metrics

* Update ClientTelemetryMetrics.java

* Update Uri.java

* Update RntbdClientChannelHealthChecker.java

* Update RntbdToken.java

* Update FaultInjectionRequestContext.java

* Update RntbdTokenStream.java

* Update RntbdTokenStream.java

* Update RntbdTokenStream.java

* EnumMap changes

* Avoiding ImmutableEnumMaps

* Fixing unit tests

* Update ClientTelemetryMetrics.java

* Update FaultInjectionRequestContext.java

* Update CHANGELOG.md

* Release preparations

* Update CHANGELOG.md

* Allowing to opt-out of E2E timeout for non-point operations via system property or environment variable (#38388)

* Allowing to opt-out of E2E timeout for non-point operations via system property or environment variable

* Tests

* Reacting to code review feedback

* remove winutils download steps (#38030)

Co-authored-by: annie-mac <xinlian@microsoft.com>

* addChannelAcquisitionContextInCosmosDiagnosticsBasedOnLatency (#38416)

* add channelAcquisitionContext in cosmosDiagnostics when reaching threshold

---------

Co-authored-by: annie-mac <xinlian@microsoft.com>

* Fixing release break for hotfix

* Update utils.py

* Update set_versions.py

* Update set_versions.py

---------

Co-authored-by: Annie Liang <64233642+xinlian12@users.noreply.github.com>
Co-authored-by: annie-mac <xinlian@microsoft.com>
FabianMeiswinkel added a commit that referenced this pull request Feb 4, 2024
@FabianMeiswinkel @xinlian12
fix set_versions.py (#38625)
9b3d1c5 
* Few minor diagnostics perf improvements (#38232)

* Check for actual meterRegistry

* Update ClientTelemetryMetrics.java

* Update ClientTelemetryMetrics.java

* Update CosmosDiagnosticsTest.java

* Removing String.format in metrics

* Update ClientTelemetryMetrics.java

* Update Uri.java

* Update RntbdClientChannelHealthChecker.java

* Update RntbdToken.java

* Update FaultInjectionRequestContext.java

* Update RntbdTokenStream.java

* Update RntbdTokenStream.java

* Update RntbdTokenStream.java

* EnumMap changes

* Avoiding ImmutableEnumMaps

* Fixing unit tests

* Update ClientTelemetryMetrics.java

* Update FaultInjectionRequestContext.java

* Update CHANGELOG.md

* Release preparations

* Update CHANGELOG.md

* Allowing to opt-out of E2E timeout for non-point operations via system property or environment variable (#38388)

* Allowing to opt-out of E2E timeout for non-point operations via system property or environment variable

* Tests

* Reacting to code review feedback

* remove winutils download steps (#38030)

Co-authored-by: annie-mac <xinlian@microsoft.com>

* addChannelAcquisitionContextInCosmosDiagnosticsBasedOnLatency (#38416)

* add channelAcquisitionContext in cosmosDiagnostics when reaching threshold

---------

Co-authored-by: annie-mac <xinlian@microsoft.com>

* Fixing release break for hotfix

* Update utils.py

* Update set_versions.py

* Update set_versions.py

* Update set_versions.py

---------

Co-authored-by: Annie Liang <64233642+xinlian12@users.noreply.github.com>
Co-authored-by: annie-mac <xinlian@microsoft.com>
FabianMeiswinkel added a commit that referenced this pull request Feb 4, 2024
@FabianMeiswinkel @xinlian12
Release azure-cosmos 4.53.2-hotfix without the version validation noi…
f59844a 
…se (#38626)

* Few minor diagnostics perf improvements (#38232)

* Check for actual meterRegistry

* Update ClientTelemetryMetrics.java

* Update ClientTelemetryMetrics.java

* Update CosmosDiagnosticsTest.java

* Removing String.format in metrics

* Update ClientTelemetryMetrics.java

* Update Uri.java

* Update RntbdClientChannelHealthChecker.java

* Update RntbdToken.java

* Update FaultInjectionRequestContext.java

* Update RntbdTokenStream.java

* Update RntbdTokenStream.java

* Update RntbdTokenStream.java

* EnumMap changes

* Avoiding ImmutableEnumMaps

* Fixing unit tests

* Update ClientTelemetryMetrics.java

* Update FaultInjectionRequestContext.java

* Update CHANGELOG.md

* Release preparations

* Update CHANGELOG.md

* Allowing to opt-out of E2E timeout for non-point operations via system property or environment variable (#38388)

* Allowing to opt-out of E2E timeout for non-point operations via system property or environment variable

* Tests

* Reacting to code review feedback

* remove winutils download steps (#38030)

Co-authored-by: annie-mac <xinlian@microsoft.com>

* addChannelAcquisitionContextInCosmosDiagnosticsBasedOnLatency (#38416)

* add channelAcquisitionContext in cosmosDiagnostics when reaching threshold

---------

Co-authored-by: annie-mac <xinlian@microsoft.com>

* Fixing release break for hotfix

* Update utils.py

* Update set_versions.py

* Update set_versions.py

* Update set_versions.py

* Update set_versions.py

---------

Co-authored-by: Annie Liang <64233642+xinlian12@users.noreply.github.com>
Co-authored-by: annie-mac <xinlian@microsoft.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FabianMeiswinkel FabianMeiswinkel FabianMeiswinkel approved these changes

@hallipr hallipr Awaiting requested review from hallipr hallipr is a code owner

@weshaggard weshaggard Awaiting requested review from weshaggard weshaggard is a code owner

@benbp benbp Awaiting requested review from benbp benbp is a code owner

@JimSuplizio JimSuplizio Awaiting requested review from JimSuplizio JimSuplizio is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@xinlian12 @FabianMeiswinkel