Allowing to opt-out of E2E timeout for non-point operations via system property or environment variable #38388
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…m property or environment variable
FabianMeiswinkel
requested review from
kushagraThapar,
kirankumarkolli,
xinlian12,
milismsft,
aayush3011,
simorenoh,
jeet1995 and
Pilchie
as code owners
|
API change check API changes are not detected in this pull request. |
…to users/fabianm/AllowDisablingE2eForNonPointOperations
sdk/cosmos/azure-cosmos/src/main/java/com/azure/cosmos/implementation/Configs.java
Show resolved
Hide resolved
kushagraThapar
approved these changes
Feb 2, 2024
|
/azp run java - cosmos - tests |
|
/azp run java - cosmos - spark |
|
Azure Pipelines successfully started running 1 pipeline(s). |
1 similar comment
|
Azure Pipelines successfully started running 1 pipeline(s). |
jeet1995
reviewed
Feb 2, 2024
...cosmos/azure-cosmos-tests/src/test/java/com/azure/cosmos/EndToEndTimeOutValidationTests.java
Outdated
Show resolved
Hide resolved
jeet1995
reviewed
Feb 2, 2024
...cosmos/azure-cosmos-tests/src/test/java/com/azure/cosmos/EndToEndTimeOutValidationTests.java
Outdated
Show resolved
Hide resolved
jeet1995
reviewed
Feb 2, 2024
...cosmos/azure-cosmos-tests/src/test/java/com/azure/cosmos/EndToEndTimeOutValidationTests.java
Outdated
Show resolved
Hide resolved
jeet1995
reviewed
Feb 2, 2024
sdk/cosmos/azure-cosmos-tests/src/test/java/com/azure/cosmos/rx/TestSuiteBase.java
Show resolved
Hide resolved
|
This PR would need a changelog entry. |
|
/azp run java - cosmos - tests |
|
/azp run java - cosmos - spark |
|
Azure Pipelines successfully started running 1 pipeline(s). |
1 similar comment
|
Azure Pipelines successfully started running 1 pipeline(s). |
FabianMeiswinkel
added a commit
to FabianMeiswinkel/azure-sdk-for-java
that referenced
this pull request
Feb 3, 2024
…m property or environment variable (Azure#38388) * Allowing to opt-out of E2E timeout for non-point operations via system property or environment variable * Tests * Reacting to code review feedback
FabianMeiswinkel
added a commit
that referenced
this pull request
Feb 4, 2024
* Few minor diagnostics perf improvements (#38232) * Check for actual meterRegistry * Update ClientTelemetryMetrics.java * Update ClientTelemetryMetrics.java * Update CosmosDiagnosticsTest.java * Removing String.format in metrics * Update ClientTelemetryMetrics.java * Update Uri.java * Update RntbdClientChannelHealthChecker.java * Update RntbdToken.java * Update FaultInjectionRequestContext.java * Update RntbdTokenStream.java * Update RntbdTokenStream.java * Update RntbdTokenStream.java * EnumMap changes * Avoiding ImmutableEnumMaps * Fixing unit tests * Update ClientTelemetryMetrics.java * Update FaultInjectionRequestContext.java * Update CHANGELOG.md * Release preparations * Update CHANGELOG.md * Allowing to opt-out of E2E timeout for non-point operations via system property or environment variable (#38388) * Allowing to opt-out of E2E timeout for non-point operations via system property or environment variable * Tests * Reacting to code review feedback * remove winutils download steps (#38030) Co-authored-by: annie-mac <xinlian@microsoft.com> * addChannelAcquisitionContextInCosmosDiagnosticsBasedOnLatency (#38416) * add channelAcquisitionContext in cosmosDiagnostics when reaching threshold --------- Co-authored-by: annie-mac <xinlian@microsoft.com> --------- Co-authored-by: Annie Liang <64233642+xinlian12@users.noreply.github.com> Co-authored-by: annie-mac <xinlian@microsoft.com>
FabianMeiswinkel
added a commit
that referenced
this pull request
Feb 4, 2024
* Few minor diagnostics perf improvements (#38232) * Check for actual meterRegistry * Update ClientTelemetryMetrics.java * Update ClientTelemetryMetrics.java * Update CosmosDiagnosticsTest.java * Removing String.format in metrics * Update ClientTelemetryMetrics.java * Update Uri.java * Update RntbdClientChannelHealthChecker.java * Update RntbdToken.java * Update FaultInjectionRequestContext.java * Update RntbdTokenStream.java * Update RntbdTokenStream.java * Update RntbdTokenStream.java * EnumMap changes * Avoiding ImmutableEnumMaps * Fixing unit tests * Update ClientTelemetryMetrics.java * Update FaultInjectionRequestContext.java * Update CHANGELOG.md * Release preparations * Update CHANGELOG.md * Allowing to opt-out of E2E timeout for non-point operations via system property or environment variable (#38388) * Allowing to opt-out of E2E timeout for non-point operations via system property or environment variable * Tests * Reacting to code review feedback * remove winutils download steps (#38030) Co-authored-by: annie-mac <xinlian@microsoft.com> * addChannelAcquisitionContextInCosmosDiagnosticsBasedOnLatency (#38416) * add channelAcquisitionContext in cosmosDiagnostics when reaching threshold --------- Co-authored-by: annie-mac <xinlian@microsoft.com> * Fixing release break for hotfix --------- Co-authored-by: Annie Liang <64233642+xinlian12@users.noreply.github.com> Co-authored-by: annie-mac <xinlian@microsoft.com>
FabianMeiswinkel
added a commit
that referenced
this pull request
Feb 4, 2024
* Few minor diagnostics perf improvements (#38232) * Check for actual meterRegistry * Update ClientTelemetryMetrics.java * Update ClientTelemetryMetrics.java * Update CosmosDiagnosticsTest.java * Removing String.format in metrics * Update ClientTelemetryMetrics.java * Update Uri.java * Update RntbdClientChannelHealthChecker.java * Update RntbdToken.java * Update FaultInjectionRequestContext.java * Update RntbdTokenStream.java * Update RntbdTokenStream.java * Update RntbdTokenStream.java * EnumMap changes * Avoiding ImmutableEnumMaps * Fixing unit tests * Update ClientTelemetryMetrics.java * Update FaultInjectionRequestContext.java * Update CHANGELOG.md * Release preparations * Update CHANGELOG.md * Allowing to opt-out of E2E timeout for non-point operations via system property or environment variable (#38388) * Allowing to opt-out of E2E timeout for non-point operations via system property or environment variable * Tests * Reacting to code review feedback * remove winutils download steps (#38030) Co-authored-by: annie-mac <xinlian@microsoft.com> * addChannelAcquisitionContextInCosmosDiagnosticsBasedOnLatency (#38416) * add channelAcquisitionContext in cosmosDiagnostics when reaching threshold --------- Co-authored-by: annie-mac <xinlian@microsoft.com> * Fixing release break for hotfix * Update utils.py --------- Co-authored-by: Annie Liang <64233642+xinlian12@users.noreply.github.com> Co-authored-by: annie-mac <xinlian@microsoft.com>
FabianMeiswinkel
added a commit
that referenced
this pull request
Feb 4, 2024
* Few minor diagnostics perf improvements (#38232) * Check for actual meterRegistry * Update ClientTelemetryMetrics.java * Update ClientTelemetryMetrics.java * Update CosmosDiagnosticsTest.java * Removing String.format in metrics * Update ClientTelemetryMetrics.java * Update Uri.java * Update RntbdClientChannelHealthChecker.java * Update RntbdToken.java * Update FaultInjectionRequestContext.java * Update RntbdTokenStream.java * Update RntbdTokenStream.java * Update RntbdTokenStream.java * EnumMap changes * Avoiding ImmutableEnumMaps * Fixing unit tests * Update ClientTelemetryMetrics.java * Update FaultInjectionRequestContext.java * Update CHANGELOG.md * Release preparations * Update CHANGELOG.md * Allowing to opt-out of E2E timeout for non-point operations via system property or environment variable (#38388) * Allowing to opt-out of E2E timeout for non-point operations via system property or environment variable * Tests * Reacting to code review feedback * remove winutils download steps (#38030) Co-authored-by: annie-mac <xinlian@microsoft.com> * addChannelAcquisitionContextInCosmosDiagnosticsBasedOnLatency (#38416) * add channelAcquisitionContext in cosmosDiagnostics when reaching threshold --------- Co-authored-by: annie-mac <xinlian@microsoft.com> * Fixing release break for hotfix * Update utils.py * Update set_versions.py --------- Co-authored-by: Annie Liang <64233642+xinlian12@users.noreply.github.com> Co-authored-by: annie-mac <xinlian@microsoft.com>
FabianMeiswinkel
added a commit
that referenced
this pull request
Feb 4, 2024
* Few minor diagnostics perf improvements (#38232) * Check for actual meterRegistry * Update ClientTelemetryMetrics.java * Update ClientTelemetryMetrics.java * Update CosmosDiagnosticsTest.java * Removing String.format in metrics * Update ClientTelemetryMetrics.java * Update Uri.java * Update RntbdClientChannelHealthChecker.java * Update RntbdToken.java * Update FaultInjectionRequestContext.java * Update RntbdTokenStream.java * Update RntbdTokenStream.java * Update RntbdTokenStream.java * EnumMap changes * Avoiding ImmutableEnumMaps * Fixing unit tests * Update ClientTelemetryMetrics.java * Update FaultInjectionRequestContext.java * Update CHANGELOG.md * Release preparations * Update CHANGELOG.md * Allowing to opt-out of E2E timeout for non-point operations via system property or environment variable (#38388) * Allowing to opt-out of E2E timeout for non-point operations via system property or environment variable * Tests * Reacting to code review feedback * remove winutils download steps (#38030) Co-authored-by: annie-mac <xinlian@microsoft.com> * addChannelAcquisitionContextInCosmosDiagnosticsBasedOnLatency (#38416) * add channelAcquisitionContext in cosmosDiagnostics when reaching threshold --------- Co-authored-by: annie-mac <xinlian@microsoft.com> * Fixing release break for hotfix * Update utils.py * Update set_versions.py * Update set_versions.py --------- Co-authored-by: Annie Liang <64233642+xinlian12@users.noreply.github.com> Co-authored-by: annie-mac <xinlian@microsoft.com>
FabianMeiswinkel
added a commit
that referenced
this pull request
Feb 4, 2024
* Few minor diagnostics perf improvements (#38232) * Check for actual meterRegistry * Update ClientTelemetryMetrics.java * Update ClientTelemetryMetrics.java * Update CosmosDiagnosticsTest.java * Removing String.format in metrics * Update ClientTelemetryMetrics.java * Update Uri.java * Update RntbdClientChannelHealthChecker.java * Update RntbdToken.java * Update FaultInjectionRequestContext.java * Update RntbdTokenStream.java * Update RntbdTokenStream.java * Update RntbdTokenStream.java * EnumMap changes * Avoiding ImmutableEnumMaps * Fixing unit tests * Update ClientTelemetryMetrics.java * Update FaultInjectionRequestContext.java * Update CHANGELOG.md * Release preparations * Update CHANGELOG.md * Allowing to opt-out of E2E timeout for non-point operations via system property or environment variable (#38388) * Allowing to opt-out of E2E timeout for non-point operations via system property or environment variable * Tests * Reacting to code review feedback * remove winutils download steps (#38030) Co-authored-by: annie-mac <xinlian@microsoft.com> * addChannelAcquisitionContextInCosmosDiagnosticsBasedOnLatency (#38416) * add channelAcquisitionContext in cosmosDiagnostics when reaching threshold --------- Co-authored-by: annie-mac <xinlian@microsoft.com> * Fixing release break for hotfix * Update utils.py * Update set_versions.py * Update set_versions.py * Update set_versions.py --------- Co-authored-by: Annie Liang <64233642+xinlian12@users.noreply.github.com> Co-authored-by: annie-mac <xinlian@microsoft.com>
FabianMeiswinkel
added a commit
that referenced
this pull request
Feb 4, 2024
…se (#38626) * Few minor diagnostics perf improvements (#38232) * Check for actual meterRegistry * Update ClientTelemetryMetrics.java * Update ClientTelemetryMetrics.java * Update CosmosDiagnosticsTest.java * Removing String.format in metrics * Update ClientTelemetryMetrics.java * Update Uri.java * Update RntbdClientChannelHealthChecker.java * Update RntbdToken.java * Update FaultInjectionRequestContext.java * Update RntbdTokenStream.java * Update RntbdTokenStream.java * Update RntbdTokenStream.java * EnumMap changes * Avoiding ImmutableEnumMaps * Fixing unit tests * Update ClientTelemetryMetrics.java * Update FaultInjectionRequestContext.java * Update CHANGELOG.md * Release preparations * Update CHANGELOG.md * Allowing to opt-out of E2E timeout for non-point operations via system property or environment variable (#38388) * Allowing to opt-out of E2E timeout for non-point operations via system property or environment variable * Tests * Reacting to code review feedback * remove winutils download steps (#38030) Co-authored-by: annie-mac <xinlian@microsoft.com> * addChannelAcquisitionContextInCosmosDiagnosticsBasedOnLatency (#38416) * add channelAcquisitionContext in cosmosDiagnostics when reaching threshold --------- Co-authored-by: annie-mac <xinlian@microsoft.com> * Fixing release break for hotfix * Update utils.py * Update set_versions.py * Update set_versions.py * Update set_versions.py * Update set_versions.py --------- Co-authored-by: Annie Liang <64233642+xinlian12@users.noreply.github.com> Co-authored-by: annie-mac <xinlian@microsoft.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds an option to opt-out of applying End-to-end timeouts for non-point operations like queries when the end-to-end timeout is defined on the CosmosClientBuilder. When the end-to-end timeout is specified on the
CosmosQueryRequestOptionsit is always applied independent of this override.The opt-out can happen either via System property
COSMOS.E2E_FOR_NON_POINT_DISABLED==trueor environment variableCOSMOS_E2E_FOR_NON_POINT_DISABLED==true