[engsys] attempt to fix warnings in js - core - ci build
#29686
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The SDL step seems to have been failing to upload artifact due to existing artifact. Not sure how it is triggered by publishing test proxy log. This PR attempts to work around the issue by changing the order of steps and deleting copied test proxy log file.
jeremymeng
requested review from
ckairen,
mikeharder,
weshaggard and
benbp
as code owners
|
Looks that SDL step gets injected before uploading artifacts. This PR won't help. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The SDL step seems to have been failing to upload artifact due to existing
artifact. Not sure how it is triggered by publishing test proxy log. This PR
attempts to work around the issue by changing the order of steps and deleting
copied test proxy log file.