Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[engsys] attempt to fix warnings in js - core - ci build #29686

Closed
wants to merge 1 commit into from
Closed

[engsys] attempt to fix warnings in js - core - ci build #29686

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 14 additions & 8 deletions eng/pipelines/templates/steps/test.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,12 +48,25 @@ steps:
displayName: "Test libraries"
condition: and(succeeded(),eq(variables['TestType'], 'browser'))

# copy first before uploading to avoid issue of file being accessed by multiple processes.
- ${{ if eq(parameters.TestProxy, true) }}:
- pwsh: |
copy $(Build.SourcesDirectory)/test-proxy.log $(Build.ArtifactStagingDirectory)
displayName: 'Dump Test Proxy logs'
condition: succeededOrFailed()


- ${{ if eq(parameters.TestProxy, true) }}:
- template: /eng/common/pipelines/templates/steps/publish-1es-artifact.yml
parameters:
ArtifactPath: '$(Build.ArtifactStagingDirectory)/test-proxy.log'
ArtifactName: 'test proxy logs $(Agent.JobName)'
SbomEnabled: false

- ${{ if eq(parameters.TestProxy, true) }}:
- pwsh: |
del $(Build.ArtifactStagingDirectory)/test-proxy.log
displayName: 'Dump Test Proxy logs'

# Unlink node_modules folders to significantly improve performance of subsequent tasks
# which need to walk the directory tree (and are hardcoded to follow symlinks).
# Retry for 30 seconds, since this command may fail with error "Another rush command is already
Expand Down Expand Up @@ -90,10 +103,3 @@ steps:
testRunTitle: "$(OSName) - Browser - Unit Tests - [Node $(NodeTestVersion)]"
condition: and(always(),eq(variables['TestType'], 'browser'))
displayName: "Publish browser unit test results"

- ${{ if eq(parameters.TestProxy, true) }}:
- template: /eng/common/pipelines/templates/steps/publish-1es-artifact.yml
parameters:
ArtifactPath: '$(Build.ArtifactStagingDirectory)/test-proxy.log'
ArtifactName: 'test proxy logs $(Agent.JobName)'
SbomEnabled: false
Loading