Skip to content

Commit

Permalink
prepare for release of Azure.Identity.Broker (#39767)
Browse files Browse the repository at this point in the history
  • Loading branch information
christothes authored Nov 6, 2023
1 parent 4b347ab commit 29d61bc
Show file tree
Hide file tree
Showing 7 changed files with 10 additions and 15 deletions.
9 changes: 2 additions & 7 deletions sdk/identity/Azure.Identity.Broker/CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,14 +1,9 @@
# Release History

## 1.0.0-beta.6 (Unreleased)

### Features Added
## 1.0.0 (2023-11-07)

### Breaking Changes

### Bugs Fixed

### Other Changes
- Renamed the `IsMsaPassthroughEnabled` property on `SharedTokenCacheCredentialBrokerOptions` to `IsLegacyMsaPassthroughEnabled`.

## 1.0.0-beta.5 (2023-10-19)

Expand Down
2 changes: 1 addition & 1 deletion sdk/identity/Azure.Identity.Broker/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@
Install the Azure Identity client library for .NET with [NuGet][nuget]:

```PowerShell
dotnet add package Azure.Identity.Broker --prerelease
dotnet add package Azure.Identity.Broker
```

### Prerequisites
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,6 @@ public partial class SharedTokenCacheCredentialBrokerOptions : Azure.Identity.Sh
{
public SharedTokenCacheCredentialBrokerOptions() { }
public SharedTokenCacheCredentialBrokerOptions(Azure.Identity.TokenCachePersistenceOptions tokenCacheOptions) { }
public bool? IsMsaPassthroughEnabled { get { throw null; } set { } }
public bool? IsLegacyMsaPassthroughEnabled { get { throw null; } set { } }
}
}
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,6 @@ public partial class SharedTokenCacheCredentialBrokerOptions : Azure.Identity.Sh
{
public SharedTokenCacheCredentialBrokerOptions() { }
public SharedTokenCacheCredentialBrokerOptions(Azure.Identity.TokenCachePersistenceOptions tokenCacheOptions) { }
public bool? IsMsaPassthroughEnabled { get { throw null; } set { } }
public bool? IsLegacyMsaPassthroughEnabled { get { throw null; } set { } }
}
}
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
<PropertyGroup>
<Description>This is the implementation of the Azure SDK Client Library for Azure Identity</Description>
<AssemblyTitle>Microsoft Azure.Identity.Broker Component</AssemblyTitle>
<Version>1.0.0-beta.6</Version>
<Version>1.0.0</Version>
<PackageTags>Microsoft Azure Identity Broker;$(PackageCommonTags)</PackageTags>
<TargetFrameworks Condition="$([MSBuild]::IsOsPlatform('Windows'))">$(RequiredTargetFrameworks);net462;net6.0</TargetFrameworks>
<TargetFrameworks Condition="$([MSBuild]::IsOsPlatform('OSX'))">$(RequiredTargetFrameworks);net6.0</TargetFrameworks>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ public class SharedTokenCacheCredentialBrokerOptions : SharedTokenCacheCredentia
/// Gets or sets whether Microsoft Account (MSA) passthrough is enabled.
/// </summary>
/// <value></value>
public bool? IsMsaPassthroughEnabled { get; set; }
public bool? IsLegacyMsaPassthroughEnabled { get; set; }

/// <summary>
/// Initializes a new instance of <see cref="SharedTokenCacheCredentialBrokerOptions"/>.
Expand All @@ -39,9 +39,9 @@ public SharedTokenCacheCredentialBrokerOptions(TokenCachePersistenceOptions toke
private void AddBroker(PublicClientApplicationBuilder builder)
{
var options = new BrokerOptions(BrokerOptions.OperatingSystems.Windows);
if (IsMsaPassthroughEnabled.HasValue)
if (IsLegacyMsaPassthroughEnabled.HasValue)
{
options.MsaPassthrough = IsMsaPassthroughEnabled.Value;
options.MsaPassthrough = IsLegacyMsaPassthroughEnabled.Value;
}
builder.WithBroker(options);
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ public void RespectsMsaPassthrough([Values(true, false, null)] bool? enableMsaPa
IMsalPublicClientInitializerOptions credentialOptions;
if (enableMsaPassthrough.HasValue)
{
credentialOptions = new SharedTokenCacheCredentialBrokerOptions { IsMsaPassthroughEnabled = enableMsaPassthrough.Value };
credentialOptions = new SharedTokenCacheCredentialBrokerOptions { IsLegacyMsaPassthroughEnabled = enableMsaPassthrough.Value };
}
else
{
Expand Down

0 comments on commit 29d61bc

Please sign in to comment.