Skip to content

Commit

Permalink
Disable diagnostics checks in tests that use released version of KeyV…
Browse files Browse the repository at this point in the history
…ault (#39912)
  • Loading branch information
lmolkova authored Nov 13, 2023
1 parent 615cfcc commit 7ec340b
Show file tree
Hide file tree
Showing 4 changed files with 8 additions and 0 deletions.
2 changes: 2 additions & 0 deletions sdk/identity/Azure.Identity/tests/IdentityRecordedTestBase.cs
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,8 @@ public abstract class IdentityRecordedTestBase : RecordedTestBase<IdentityTestEn
{
protected IdentityRecordedTestBase(bool isAsync, RecordedTestMode? mode = default) : base(isAsync, mode)
{
// TODO: enable after new KeyValue is released (after Dec 2023)
TestDiagnostics = false;
InitializeRecordingSettings();
}

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,8 @@ public class ManagedIdentityCredentialLiveTestBase : IdentityRecordedTestBase
{
public ManagedIdentityCredentialLiveTestBase(bool isAsync) : base(isAsync)
{
// TODO: enable after new KeyValue is released (after Dec 2023)
TestDiagnostics = false;
}

public ManagedIdentityCredentialLiveTestBase(bool isAsync, RecordedTestMode mode) : base(isAsync, mode)
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -37,6 +37,8 @@ public class ClientSideEncryptionTests : BlobTestBase
public ClientSideEncryptionTests(bool async, BlobClientOptions.ServiceVersion serviceVersion)
: base(async, serviceVersion, null /* RecordedTestMode.Record /* to re-record */)
{
// TODO: enable after new KeyValue is released (after Dec 2023)
TestDiagnostics = false;
}

private static IEnumerable<ClientSideEncryptionVersion> GetEncryptionVersions()
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -39,6 +39,8 @@ public class ClientSideEncryptionTests : QueueTestBase
public ClientSideEncryptionTests(bool async)
: base(async, null /* RecordedTestMode.Record /* to re-record */)
{
// TODO: enable after new KeyValue is released (after Dec 2023)
TestDiagnostics = false;
}

private static IEnumerable<ClientSideEncryptionVersion> GetEncryptionVersions()
Expand Down

0 comments on commit 7ec340b

Please sign in to comment.