Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ServiceBusProcessor RunReceiveTaskAsync small improvements #19665

Merged
merged 5 commits into from
Mar 23, 2021

Conversation

danielmarbach
Copy link
Contributor

@danielmarbach danielmarbach commented Mar 21, 2021

All SDK Contribution checklist:

This checklist is used to make sure that common guidelines for a pull request are followed.

  • Please open PR in Draft mode if it is:
    • Work in progress or not intended to be merged.
    • Encountering multiple pipeline failures and working on fixes.
  • If an SDK is being regenerated based on a new swagger spec, a link to the pull request containing these swagger spec changes has been included above.
  • I have read the contribution guidelines.
  • The pull request does not introduce breaking changes.

General Guidelines and Best Practices

  • Title of the pull request is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

  • Pull request includes test coverage for the included changes.

SDK Generation Guidelines

  • The generate.cmd file for the SDK has been updated with the version of AutoRest, as well as the commitid of your swagger spec or link to the swagger spec, used to generate the code. (Track 2 only)
  • The *.csproj and AssemblyInfo.cs files have been updated with the new version of the SDK. Please double check nuget.org current release version.

Additional management plane SDK specific contribution checklist:

Note: Only applies to Microsoft.Azure.Management.[RP] or Azure.ResourceManager.[RP]

  • Include updated management metadata.
  • Update AzureRP.props to add/remove version info to maintain up to date API versions.

Management plane SDK Troubleshooting

  • If this is very first SDK for a services and you are adding new service folders directly under /SDK, please add new service label and/or contact assigned reviewer.
  • If the check fails at the Verify Code Generation step, please ensure:
    • Do not modify any code in generated folders.
    • Do not selectively include/remove generated files in the PR.
    • Do use generate.ps1/cmd to generate this PR instead of calling autorest directly.
      Please pay attention to the @microsoft.csharp version output after running generate.ps1. If it is lower than current released version (2.3.82), please run it again as it should pull down the latest version,

Old outstanding PR cleanup

Please note:
If PRs (including draft) has been out for more than 60 days and there are no responses from our query or followups, they will be closed to maintain a concise list for our reviewers.

@danielmarbach
Copy link
Contributor Author

BenchmarkDotNet=v0.12.1, OS=Windows 10.0.19042
AMD Ryzen Threadripper 1920X, 1 CPU, 24 logical and 12 physical cores
.NET Core SDK=5.0.200
  [Host]     : .NET Core 3.1.12 (CoreCLR 4.700.21.6504, CoreFX 4.700.21.6905), X64 RyuJIT
  DefaultJob : .NET Core 3.1.12 (CoreCLR 4.700.21.6504, CoreFX 4.700.21.6905), X64 RyuJIT

Method Elements Mean Error StdDev StdErr Min Q1 Median Q3 Max Op/s Ratio RatioSD Gen 0 Gen 1 Gen 2 Allocated
List 2 20.11 ns 0.432 ns 0.891 ns 0.124 ns 18.73 ns 19.39 ns 19.80 ns 20.78 ns 22.29 ns 49,722,814.5 1.00 0.00 0.0115 - - 48 B
IList 2 48.17 ns 0.506 ns 0.448 ns 0.120 ns 47.53 ns 47.84 ns 48.12 ns 48.44 ns 49.00 ns 20,758,378.3 2.38 0.12 0.0210 - - 88 B
Enumberable 2 50.23 ns 1.026 ns 1.221 ns 0.267 ns 47.65 ns 49.85 ns 50.37 ns 51.24 ns 51.91 ns 19,909,596.3 2.49 0.12 0.0210 - - 88 B
List 4 35.50 ns 0.729 ns 0.895 ns 0.191 ns 34.15 ns 34.79 ns 35.53 ns 36.09 ns 37.18 ns 28,171,958.6 1.00 0.00 0.0229 - - 96 B
IList 4 80.47 ns 0.824 ns 0.688 ns 0.191 ns 79.71 ns 79.96 ns 80.35 ns 80.88 ns 81.99 ns 12,427,686.5 2.28 0.06 0.0324 - - 136 B
Enumberable 4 84.64 ns 1.704 ns 1.894 ns 0.434 ns 81.92 ns 83.38 ns 84.73 ns 86.05 ns 87.98 ns 11,814,945.1 2.38 0.06 0.0324 - - 136 B
List 8 73.30 ns 1.395 ns 1.661 ns 0.362 ns 69.67 ns 72.54 ns 73.34 ns 74.25 ns 76.31 ns 13,643,417.5 1.00 0.00 0.0459 - - 192 B
IList 8 124.20 ns 1.140 ns 0.952 ns 0.264 ns 122.68 ns 123.59 ns 123.78 ns 124.94 ns 126.00 ns 8,051,732.7 1.70 0.04 0.0554 - - 232 B
Enumberable 8 129.14 ns 2.584 ns 2.417 ns 0.624 ns 124.57 ns 128.27 ns 129.78 ns 130.83 ns 132.62 ns 7,743,440.8 1.77 0.06 0.0554 - - 232 B
List 16 136.56 ns 2.730 ns 4.408 ns 0.756 ns 128.56 ns 133.83 ns 135.97 ns 139.46 ns 145.26 ns 7,322,942.5 1.00 0.00 0.0918 - - 384 B
IList 16 230.32 ns 3.650 ns 3.414 ns 0.881 ns 225.22 ns 227.91 ns 229.60 ns 233.53 ns 236.09 ns 4,341,829.1 1.70 0.07 0.1013 - - 424 B
Enumberable 16 225.51 ns 3.374 ns 2.991 ns 0.799 ns 221.37 ns 223.09 ns 224.98 ns 227.60 ns 230.69 ns 4,434,326.8 1.67 0.07 0.1013 - - 424 B
List 32 251.16 ns 4.659 ns 7.785 ns 1.297 ns 240.31 ns 248.03 ns 249.43 ns 252.18 ns 273.52 ns 3,981,566.2 1.00 0.00 0.1836 - - 768 B
IList 32 413.48 ns 8.004 ns 7.861 ns 1.965 ns 402.34 ns 406.48 ns 413.98 ns 420.30 ns 424.17 ns 2,418,472.9 1.63 0.07 0.1931 - - 808 B
Enumberable 32 427.95 ns 5.640 ns 5.276 ns 1.362 ns 417.11 ns 425.79 ns 427.62 ns 431.69 ns 436.52 ns 2,336,695.5 1.69 0.08 0.1931 - - 808 B
List 64 488.62 ns 7.036 ns 6.581 ns 1.699 ns 476.90 ns 483.35 ns 488.76 ns 493.52 ns 499.05 ns 2,046,566.6 1.00 0.00 0.3672 - - 1536 B
IList 64 806.32 ns 14.437 ns 13.505 ns 3.487 ns 790.80 ns 795.06 ns 802.58 ns 815.75 ns 835.91 ns 1,240,195.3 1.65 0.04 0.3767 - - 1576 B
Enumberable 64 816.37 ns 15.504 ns 16.589 ns 3.910 ns 788.98 ns 810.23 ns 815.21 ns 829.59 ns 845.21 ns 1,224,931.0 1.67 0.04 0.3767 - - 1576 B
List 128 998.00 ns 19.745 ns 24.971 ns 5.207 ns 951.84 ns 983.82 ns 998.96 ns 1,013.01 ns 1,052.73 ns 1,002,002.8 1.00 0.00 0.7343 - - 3072 B
IList 128 1,539.97 ns 13.098 ns 12.252 ns 3.163 ns 1,509.72 ns 1,535.43 ns 1,540.87 ns 1,545.93 ns 1,557.64 ns 649,364.4 1.54 0.03 0.7439 - - 3112 B
Enumberable 128 1,596.92 ns 31.910 ns 41.492 ns 8.469 ns 1,499.48 ns 1,572.35 ns 1,602.28 ns 1,616.30 ns 1,677.54 ns 626,204.0 1.60 0.06 0.7439 - - 3112 B

@ghost ghost added the customer-reported Issues that are reported by GitHub users external to the Azure organization. label Mar 21, 2021
@ghost
Copy link

ghost commented Mar 21, 2021

Thank you for your contribution @danielmarbach! We will review the pull request and get back to you soon.

@ghost ghost added the Community Contribution Community members are working on the issue label Mar 21, 2021
Copy link
Member

@jsquire jsquire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM; I'll defer to Josh on the final call and am going to kick off the live tests.

@jsquire
Copy link
Member

jsquire commented Mar 21, 2021

/azp run net - servicebus - tests

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@JoshLove-msft
Copy link
Member

/azp run net - servicebus - tests

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@JoshLove-msft
Copy link
Member

/azp run net - servicebus - tests

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@danielmarbach
Copy link
Contributor Author

🎆

Copy link
Member

@JoshLove-msft JoshLove-msft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@danielmarbach thanks for the PR!

@JoshLove-msft JoshLove-msft merged commit 8834150 into Azure:master Mar 23, 2021
@danielmarbach danielmarbach deleted the receiver branch March 23, 2021 20:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Community Contribution Community members are working on the issue customer-reported Issues that are reported by GitHub users external to the Azure organization. Service Bus
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants