Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support cancellation for send and receive #24215

Merged
merged 5 commits into from
Sep 28, 2021

Conversation

JoshLove-msft
Copy link
Member

@JoshLove-msft JoshLove-msft commented Sep 24, 2021

Fixes #21869

@JoshLove-msft
Copy link
Member Author

/azp run net - servicebus - tests

@JoshLove-msft
Copy link
Member Author

/azp run net - eventhub - tests

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

1 similar comment
@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

Copy link
Member

@jsquire jsquire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That saved a ton of boilerplate!

@JoshLove-msft
Copy link
Member Author

/azp run net - servicebus - tests

@JoshLove-msft
Copy link
Member Author

/azp run net - eventhub - tests

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

1 similar comment
@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@JoshLove-msft
Copy link
Member Author

/azp run net - servicebus - tests

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@JoshLove-msft
Copy link
Member Author

/azp run net - servicebus - tests

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@JoshLove-msft
Copy link
Member Author

/azp run net - servicebus - tests

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@JoshLove-msft
Copy link
Member Author

Ran into an issue while testing - fixed in Azure/azure-amqp#202

@JoshLove-msft
Copy link
Member Author

/azp run net - servicebus - tests

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@JoshLove-msft JoshLove-msft enabled auto-merge (squash) September 28, 2021 03:20
@JoshLove-msft JoshLove-msft merged commit 908e61d into Azure:main Sep 28, 2021
@WojcikMike
Copy link

Is there any ETA when this will be released? We found an odd behavior when testing the support of cancellation token and we believe that this change should make it better.

@JoshLove-msft
Copy link
Member Author

Is there any ETA when this will be released? We found an odd behavior when testing the support of cancellation token and we believe that this change should make it better.

Yes, this should be released tomorrow (10/5).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Stopping ServiceBusProcessor causes some messages to be left locked
3 participants