-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding WebPubSubService provisioning #43027
Conversation
@jsquire do we want to add this to the codeowners list too? I think it would be valuable but I usually see you gatekeep so wanted to check with you. |
Yeah, it's past time that @JoshLove-msft and @tg-msft were added as owners for provisioning. I'll put out a PR for this tomorrow if Josh doesn't beat me to it. |
Hi @JoshLove-msft, could you provide guidance on running and testing the test? The CI throws with |
Yes, we would need to generate the bicep serialization in the Azure.ResourceManager.WebPubSub library. Here is an example https://github.com/Azure/azure-sdk-for-net/blob/main/sdk/servicebus/Azure.ResourceManager.ServiceBus/src/autorest.md showing the property that needs to be set:
Once this property is set, you would need to regenerate that library, and then we would need to ship a new GA version with the bicep serialization. |
API change check APIView has identified API level changes in this PR and created following API reviews. |
Looks like CI fails on unrelated tests |
Contributing to the Azure SDK
Please see our CONTRIBUTING.md if you are not familiar with contributing to this repository or have questions.
For specific information about pull request etiquette and best practices, see this section.
Adding WebPubSubService provisioning for dotnet/aspire#2495