Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Personalizer : Delete apis other than rank, reward and activate #6041

Merged
merged 3 commits into from
May 2, 2019
Merged

Personalizer : Delete apis other than rank, reward and activate #6041

merged 3 commits into from
May 2, 2019

Conversation

dwaijam
Copy link
Contributor

@dwaijam dwaijam commented May 2, 2019

Delete apis other than rank, reward and activate

azure-rest-api-specs PR - Azure/azure-rest-api-specs#5835

@dsgouda dsgouda mentioned this pull request May 2, 2019
Closed
dsgouda
dsgouda suggested changes May 2, 2019
View reviewed changes
Copy link
Contributor

@dsgouda dsgouda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please regenerate this code using generate.ps1 and commit all changes generated (including .txt files)
While you are at it, please remove -SdkGenerationDirectory "$PSScriptRoot\Generated\Personalizer" and check where the code is generated. The generated files must be under Personalizer\Personalizer\Generated instead of Personalizer\Personalizer\Generated\Personalizer

@dwaijam
Copy link
Contributor Author

dwaijam commented May 2, 2019

Please regenerate this code using generate.ps1 and commit all changes generated (including .txt files)
While you are at it, please remove -SdkGenerationDirectory "$PSScriptRoot\Generated\Personalizer" and check where the code is generated. The generated files must be under Personalizer\Personalizer\Generated instead of Personalizer\Personalizer\Generated\Personalizer

fixed

dsgouda
dsgouda approved these changes May 2, 2019
View reviewed changes
Copy link
Contributor

@dsgouda dsgouda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dsgouda
Copy link
Contributor

dsgouda commented May 2, 2019

Will merge once CIs pass

@dsgouda dsgouda merged commit 7137006 into Azure:master May 2, 2019
dwaijam added a commit to tyclintw/azure-sdk-for-net that referenced this pull request May 6, 2019
@dwaijam
Revert "Personalizer : Delete apis other than rank, reward and activa…
3775a81 
…te (Azure#6041)"

This reverts commit 7137006.
mentat9 pushed a commit to mentat9/azure-sdk-for-net that referenced this pull request Jun 10, 2019
@dwaijam @mentat9
Personalizer : Delete apis other than rank, reward and activate (Azur…
4fa2399 
…e#6041)

* Delete apis other than rank, reward and activate

* update sdkinfo and txt file, add feedback.md as requested for nuget publish

* change personalizer sdk generated files location
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dsgouda dsgouda dsgouda approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dwaijam @dsgouda