Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed storage account keys example #686

Closed
wants to merge 1 commit into from
Closed

Conversation

clehene
Copy link

@clehene clehene commented Jul 14, 2016

No description provided.

@clehene clehene closed this Jul 14, 2016
@clehene clehene deleted the patch-1 branch July 14, 2016 22:38
@coveralls
Copy link

coveralls commented Jul 14, 2016

Coverage Status

Coverage remained the same at 41.862% when pulling e282c0a on clehene:patch-1 into 33e7180 on Azure:master.

@lmazuel
Copy link
Member

lmazuel commented Jul 14, 2016

Hi @clehene

You are right, I forgot to update readthedocs. I just made it:
cee8ae4

Thanks!

@clehene
Copy link
Author

clehene commented Jul 15, 2016

@lmazuel I closed the PR because it was incomplete / incorrect. However why not just leave it (and the test) with .keys[0].value instead ['key1'] and skip the map creation altogether

@lmazuel
Copy link
Member

lmazuel commented Jul 15, 2016

By using keys[0] I don't know if I use the key1 or key2. Even if it's not really critical, the right way to migrate from .key1 to the new API is to build a map a explicitly get ['key1'].

@clehene
Copy link
Author

clehene commented Jul 15, 2016

@lmazuel ouch! I was assuming keys[0] name is key1. Is this captured in the documentation somewhere? If not it would be useful to explicitly mention what's going on, to avoid wrong assumptions (such as mine) :)

@lmazuel
Copy link
Member

lmazuel commented Jul 15, 2016

As you can see here, the Storage 2016-01-01 API Version has changed from fixed "key1"/"key2" key names to a list of key objects where "key1"/"key2" are just regular name:
https://msdn.microsoft.com/en-us/library/azure/mt163589.aspx

This open the possibility in the future to decide to choose a customized key name (I don't say it's in any roadmap, just that this is now possible to think about it).

This means that even if the example shows the list in the "key1"/"key2" order, this is not a requirement and the object order in the list might changed in the RestAPI answer. In addition, the order might be changed by the implementation and might be inconsistent between C#, Java, Python, etc.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants