-
Notifications
You must be signed in to change notification settings - Fork 177
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
When installing dev package, target a specific index #3189
Conversation
This pull request is protected by Check Enforcer. What is Check Enforcer?Check Enforcer helps ensure all pull requests are covered by at least one check-run (typically an Azure Pipeline). When all check-runs associated with this pull request pass then Check Enforcer itself will pass. Why am I getting this message?You are getting this message because Check Enforcer did not detect any check-runs being associated with this pull request within five minutes. This may indicate that your pull request is not covered by any pipelines and so Check Enforcer is correctly blocking the pull request being merged. What should I do now?If the check-enforcer check-run is not passing and all other check-runs associated with this PR are passing (excluding license-cla) then you could try telling Check Enforcer to evaluate your pull request again. You can do this by adding a comment to this pull request as follows: |
@scbedd I think targeting a specific index makes sense, but shouldn't it be here, not the SDK? Didn't you move the pylint-guidelines-checker to this repo? |
I see. I'm just an idiot where I blindly updated this install. |
@tjprescott No I think this is right. This In the pipeline checking this api stub generator, do we want to use the version being developed or the same one as what APIView uses? If it's just "use what's developed" then I totally agree and will add a relative install, otherwise, we need to install from a specific feed, not using |
@scbedd we should what APIView uses so this looks like the right approach. Thank you! |
This PR will fail until this other PR is invoked for the dependent packages. |
/azp run tools - api-stub-generator - ci |
/azp run tools - api-stub-generator - ci |
No pipelines are associated with this pull request. |
/azp run tools - api-stub-generator - ci |
Azure Pipelines successfully started running 1 pipeline(s). |
@praveenkuttappan @tjprescott I am pretty certain this will be fine for our runs.
Does this same concern affect how we currently install the api-stub-generator during APIView deploy?