Add support for Federated Auth to test resources scripts #8249
Conversation
|
The following pipelines have been queued for testing: |
There was a problem hiding this comment.
A couple comments but looking good. @weshaggard to take a look.
|
The following pipelines have been queued for testing: |
|
The following pipelines have been queued for testing: |
|
| # If no test application ID was specified during an interactive session, create a new service principal. | ||
| elseif (!$CI -and !$TestApplicationId) { | ||
| # If user has specified -ServicePrincipalAuth | ||
| elseif (!$CI -and $ServicePrincipalAuth) { |
There was a problem hiding this comment.
Seems this needs to require $TestApplicationId, then. PowerShell does support a rich set of APIs for validating parameters if you want to know more. It's more idiomatic and does positively affect the CLI.
There was a problem hiding this comment.
We changed behavior in the script to default to the -UserAuth behavior of today. -ServicePrinipalAuth creates a service principal on behalf of the user for testing.
Perhaps this should be something more like -CreateServicePrincipal
Either way TestApplicationId would be ignored.
There was a problem hiding this comment.
We kept the name -ServicePrincipalAuth but changed the behaviors a bit. We now use ServicePrincipalAuth to determine whether to log in as the provisioner app optionally supplied in -ProvisionerApplication___ or to create a service principal on behalf of the user if no provisioner app info is supplied.
The -UserAuth param was removed and it's now the default behavior.
|
The following pipelines have been queued for testing: |
|
The following pipelines have been queued for testing: |
|
The following pipelines have been queued for testing: |
Sync eng/common directory with azure-sdk-tools for PR Azure/azure-sdk-tools#8249 See [eng/common workflow](https://github.com/Azure/azure-sdk-tools/blob/main/eng/common/README.md#workflow) --------- Co-authored-by: Daniel Jurek <djurek@microsoft.com>
Fiixes #8245