Skip to content

Conversation

sourabh1007
Copy link
Contributor

@sourabh1007 sourabh1007 commented Feb 13, 2024

Why make this change?

No Code Change as of Now.

What is this change?

Added tests to cover scenarios related to auth in cosmos DB, with below config changes:
a) Added different combinations of role for Earth entity
b) Removed Anonymous role for Earth entity

NOTE: Item level authorization tests are not covered here.

How was this tested?

  • Integration Tests
  • Unit Tests

@sourabh1007 sourabh1007 force-pushed the users/sourabhjain/authtests branch from 34b84c8 to a3c4d18 Compare February 13, 2024 15:46
@sourabh1007 sourabh1007 force-pushed the users/sourabhjain/authtests branch from a3c4d18 to f3bf743 Compare February 14, 2024 01:37
@sourabh1007 sourabh1007 force-pushed the users/sourabhjain/authtests branch from 62929c1 to a71232a Compare February 14, 2024 05:54
@sourabh1007 sourabh1007 force-pushed the users/sourabhjain/authtests branch from 6e938be to bcb5bbd Compare February 14, 2024 07:08
@sourabh1007
Copy link
Contributor Author

/azp run

Copy link

Azure Pipelines successfully started running 3 pipeline(s).

@sourabh1007
Copy link
Contributor Author

/azp run

Copy link

Azure Pipelines successfully started running 3 pipeline(s).

@sourabh1007
Copy link
Contributor Author

/azp run

Copy link

Azure Pipelines successfully started running 3 pipeline(s).

@sourabh1007 sourabh1007 enabled auto-merge (squash) February 15, 2024 01:21
Copy link
Contributor

@seantleonard seantleonard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

some suggestions on more informative displaynames for tests.

@sourabh1007
Copy link
Contributor Author

/azp run

Copy link

Azure Pipelines successfully started running 3 pipeline(s).

@sourabh1007
Copy link
Contributor Author

/azp run

Copy link

Azure Pipelines successfully started running 3 pipeline(s).

Copy link
Contributor

@seantleonard seantleonard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

last nits, then should be good. Thanks for addressing feedback!

sourabh1007 and others added 2 commits February 15, 2024 22:50
Co-authored-by: Sean Leonard <sean.leonard@microsoft.com>
@sourabh1007
Copy link
Contributor Author

/azp run

Copy link

Azure Pipelines successfully started running 3 pipeline(s).

Copy link
Contributor

@seantleonard seantleonard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for addressing feedback to make tests/comments add clarity. Clarity will be helpful for us to understand context when we or other devs come back to read this in future.

@sourabh1007 sourabh1007 merged commit 165ba8a into main Feb 16, 2024
@sourabh1007 sourabh1007 deleted the users/sourabhjain/authtests branch February 16, 2024 16:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants