-
Notifications
You must be signed in to change notification settings - Fork 279
Cosmos DB: Added Authorization related tests #2034
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
34b84c8
to
a3c4d18
Compare
a3c4d18
to
f3bf743
Compare
62929c1
to
a71232a
Compare
6e938be
to
bcb5bbd
Compare
/azp run |
Azure Pipelines successfully started running 3 pipeline(s). |
/azp run |
Azure Pipelines successfully started running 3 pipeline(s). |
/azp run |
Azure Pipelines successfully started running 3 pipeline(s). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
some suggestions on more informative displaynames for tests.
src/Service.Tests/Snapshots/ConfigurationTests.TestReadingRuntimeConfigForCosmos.verified.txt
Show resolved
Hide resolved
/azp run |
Azure Pipelines successfully started running 3 pipeline(s). |
/azp run |
Azure Pipelines successfully started running 3 pipeline(s). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
last nits, then should be good. Thanks for addressing feedback!
Co-authored-by: Sean Leonard <sean.leonard@microsoft.com>
/azp run |
Azure Pipelines successfully started running 3 pipeline(s). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for addressing feedback to make tests/comments add clarity. Clarity will be helpful for us to understand context when we or other devs come back to read this in future.
Why make this change?
No Code Change as of Now.
What is this change?
Added tests to cover scenarios related to auth in cosmos DB, with below config changes:
a) Added different combinations of role for
Earth
entityb) Removed
Anonymous
role forEarth
entityNOTE: Item level authorization tests are not covered here.
How was this tested?