Skip to content

Conversation

abhishekkumams
Copy link
Contributor

@abhishekkumams abhishekkumams commented Feb 15, 2024

Why make this change?

What is this change?

  • RuntimeConfig object stores dataSourceName information.
  • previously the RuntimeConfig object was created in CLI during deserialization and sent to Engine Code. And In engine code when we setup metadatprovider we again create the dataSourceName info, due to which there is a mismatch.
  • So, we are not sending the RuntimeConfig object from CLI, and in Engine we are sourcing it directly from RuntimeConfigProvider. (similar to how it's done while starting the engine).
  • Therefore, Doing the deserialization only in a single place in the engine itself, improving performance as well.

Before

image

After

image

@abhishekkumams abhishekkumams changed the title fix dataSourceName mismatch fix dataSourceName not found exception in dab validate Feb 15, 2024
@abhishekkumams abhishekkumams self-assigned this Feb 16, 2024
@abhishekkumams abhishekkumams added the bug Something isn't working label Feb 16, 2024
@abhishekkumams abhishekkumams added this to the 0.12rc milestone Feb 16, 2024
@abhishekkumams
Copy link
Contributor Author

/azp run

Copy link

Azure Pipelines successfully started running 3 pipeline(s).

@abhishekkumams
Copy link
Contributor Author

/azp run

Copy link

Azure Pipelines successfully started running 2 pipeline(s).

Copy link
Collaborator

@Aniruddh25 Aniruddh25 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs the right testing

@abhishekkumams
Copy link
Contributor Author

/azp run

Copy link

Azure Pipelines successfully started running 2 pipeline(s).

@abhishekkumams
Copy link
Contributor Author

/azp run

Copy link

Azure Pipelines successfully started running 2 pipeline(s).

@abhishekkumams
Copy link
Contributor Author

/azp run

Copy link

Azure Pipelines successfully started running 2 pipeline(s).

@abhishekkumams abhishekkumams enabled auto-merge (squash) February 23, 2024 09:27
@abhishekkumams
Copy link
Contributor Author

/azp run

Copy link

Azure Pipelines successfully started running 2 pipeline(s).

@abhishekkumams
Copy link
Contributor Author

/azp run

Copy link

Azure Pipelines successfully started running 2 pipeline(s).

@abhishekkumams abhishekkumams merged commit 9846181 into main Feb 23, 2024
@abhishekkumams abhishekkumams deleted the dev/abhishekkuma/fix_unhandled_exception_in_dab_validate branch February 23, 2024 18:49
@Aniruddh25 Aniruddh25 changed the title fix dataSourceName not found exception in dab validate Fix dataSourceName not found exception in dab validate Feb 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: dab validate getting exception due to datasourceName mismatch
4 participants