-
Notifications
You must be signed in to change notification settings - Fork 279
Stored proc support test cases REST DW. #2048
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Stored proc support test cases REST DW. #2048
Conversation
/azp run |
src/Service.Tests/SqlTests/RestApiTests/Delete/DwSqlDeleteApiTest.cs
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you have Find,Delete, and Insert. Do you plan to add DW StoredProc tests for Patch/Put?
…/github.com/Azure/data-api-builder into rohkhann/DWMutationAndStoredProcRestSupport
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks for making these changes and good to see follow up issue for PUT/PATCH.
/azp run |
Azure Pipelines successfully started running 2 pipeline(s). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Need to fix test cases
/azp run |
Azure Pipelines successfully started running 2 pipeline(s). |
/azp run |
Azure Pipelines successfully started running 2 pipeline(s). |
c63cbac
to
1f9771a
Compare
/azp run |
Azure Pipelines successfully started running 2 pipeline(s). |
/azp run |
Azure Pipelines successfully started running 2 pipeline(s). |
src/Service.Tests/SqlTests/RestApiTests/Insert/DwSqlInsertApiTests.cs
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks for adding the test gap and uncovering additional missing gaps as tracked by the new issues
Why make this change?
This change adds appropriate test cases that validates the REST support for stored procedures for Data warehouse.
What is this change?
This change adds test cases needed to validate stored proc rest support in dab. It only adds test cases currently supported for other db types.
How was this tested?
test cases added.