Skip to content

Conversation

rohkhann
Copy link
Contributor

@rohkhann rohkhann commented Feb 16, 2024

Why make this change?

This change adds appropriate test cases that validates the REST support for stored procedures for Data warehouse.

What is this change?

This change adds test cases needed to validate stored proc rest support in dab. It only adds test cases currently supported for other db types.

  1. Find: For find, we remove the overriden test cases in the dab class. this means the code will execute the test cases in the base classes for DW.
  2. Delete: Add the delete class for dwtests that inherits off of the base. (delete support exists for rest dw case as for delete we return no content as opposed to insert). The specific test cases that need to be overriden due to DW specific implementations have been overriden and added to the delete test cases file.
  3. PUT/PATCH: There are no stored proc specific tests for PUT/PATCH for other db's and hence none added here. Tracked in this issue: Test cases for PUT/PATCH for all db types for stored proc scenario #2085
  4. Insert: There is one test case pertaining to stored proc insert that is added for other db's. That is not included in this pr, as since we would want to inherit from the InsertTestBase class, other insert tests would also execute. As compared to delete, insert on rest, currently expects the inserted object to be returned. In DW, we have gone with option of only returning success/failure for mutation operations instead of the result and that logic + test cases will be implemented in REST support for datawarehouse CUD operations (analogous to what mutations support in GQL) #1982

How was this tested?

test cases added.

@rohkhann
Copy link
Contributor Author

/azp run

Copy link
Contributor

@aaronburtle aaronburtle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Contributor

@seantleonard seantleonard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you have Find,Delete, and Insert. Do you plan to add DW StoredProc tests for Patch/Put?

Copy link
Contributor

@seantleonard seantleonard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for making these changes and good to see follow up issue for PUT/PATCH.

@rohkhann
Copy link
Contributor Author

rohkhann commented Mar 8, 2024

/azp run

Copy link

Azure Pipelines successfully started running 2 pipeline(s).

Copy link
Collaborator

@Aniruddh25 Aniruddh25 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need to fix test cases

@rohkhann
Copy link
Contributor Author

/azp run

Copy link

Azure Pipelines successfully started running 2 pipeline(s).

@rohkhann rohkhann requested a review from Aniruddh25 March 11, 2024 19:50
@rohkhann
Copy link
Contributor Author

/azp run

@rohkhann rohkhann requested a review from seantleonard March 11, 2024 22:30
Copy link

Azure Pipelines successfully started running 2 pipeline(s).

@rohkhann rohkhann force-pushed the rohkhann/DWMutationAndStoredProcRestSupport branch from c63cbac to 1f9771a Compare March 11, 2024 23:13
@rohkhann
Copy link
Contributor Author

/azp run

Copy link

Azure Pipelines successfully started running 2 pipeline(s).

@rohkhann
Copy link
Contributor Author

/azp run

Copy link

Azure Pipelines successfully started running 2 pipeline(s).

@rohkhann rohkhann requested a review from Aniruddh25 March 12, 2024 00:01
Copy link
Collaborator

@Aniruddh25 Aniruddh25 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for adding the test gap and uncovering additional missing gaps as tracked by the new issues

@Aniruddh25 Aniruddh25 merged commit 894cbeb into main Mar 12, 2024
@Aniruddh25 Aniruddh25 deleted the rohkhann/DWMutationAndStoredProcRestSupport branch March 12, 2024 23:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants