Skip to content

Condition OpenAPI document creation to non-CosmosDB database types. #2072

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Mar 10, 2024
Merged

Condition OpenAPI document creation to non-CosmosDB database types. #2072

merged 7 commits into from
Mar 10, 2024

Conversation

seantleonard
Copy link
Contributor

Why make this change?

What is this change?

  • OpenAPI documentor service init only occurs for non-CosmosDB database types because db types like MSSQL , PG, MySQL are the only db types that support the REST endpoint in DAB.

How was this tested?

  • Run DAB with CosmosDB set as db type and ensure OpenAPI init failure is not logged to console.
    image

Aniruddh25
Aniruddh25 reviewed Mar 5, 2024
View reviewed changes
@seantleonard
Copy link
Contributor Author

/azp run

@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines successfully started running 2 pipeline(s).

@seantleonard
Copy link
Contributor Author

/azp run

@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines successfully started running 2 pipeline(s).

severussundar
severussundar approved these changes Mar 6, 2024
View reviewed changes
Copy link
Contributor

@severussundar severussundar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@seantleonard
Copy link
Contributor Author

/azp run

@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines successfully started running 2 pipeline(s).

@seantleonard seantleonard enabled auto-merge (squash) March 8, 2024 01:29
Aniruddh25
Aniruddh25 reviewed Mar 10, 2024
View reviewed changes
@Aniruddh25
Copy link
Collaborator

/azp run

@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines successfully started running 2 pipeline(s).

@seantleonard seantleonard merged commit 08f4d45 into main Mar 10, 2024
@seantleonard seantleonard deleted the dev/sean/cosmos_openapi_messaging branch March 10, 2024 22:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Aniruddh25 Aniruddh25 Aniruddh25 approved these changes

@severussundar severussundar severussundar approved these changes

@mbhaskar mbhaskar Awaiting requested review from mbhaskar

@JelteF JelteF Awaiting requested review from JelteF

@Mathos1432 Mathos1432 Awaiting requested review from Mathos1432

@gledis69 gledis69 Awaiting requested review from gledis69

@aaronburtle aaronburtle Awaiting requested review from aaronburtle aaronburtle is a code owner

@tarazou9 tarazou9 Awaiting requested review from tarazou9

@ayush3797 ayush3797 Awaiting requested review from ayush3797

@abhishekkumams abhishekkumams Awaiting requested review from abhishekkumams

@aaronpowell aaronpowell Awaiting requested review from aaronpowell

@ravishetye ravishetye Awaiting requested review from ravishetye

@rohkhann rohkhann Awaiting requested review from rohkhann

@neeraj-sharma2592 neeraj-sharma2592 Awaiting requested review from neeraj-sharma2592 neeraj-sharma2592 is a code owner

@sourabh1007 sourabh1007 Awaiting requested review from sourabh1007 sourabh1007 is a code owner

Assignees

@severussundar severussundar

@ayush3797 ayush3797

@rohkhann rohkhann

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug]: Console logged "error" when DBtype is Cosmos and OpenAPI service fails to generate doc
5 participants
@seantleonard @Aniruddh25 @severussundar @ayush3797 @rohkhann