-
Notifications
You must be signed in to change notification settings - Fork 279
Update DAB CLI to return appropriate exit codes based upon exit reason #2084
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…revision can explore returning specific codes for each unique error.
/azp run |
Azure Pipelines successfully started running 2 pipeline(s). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking for const codes to indicate success or error
…ure/data-api-builder into dev/sean/cli_validReturnCodes
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, just a nit.
…ults in error tracking. also added "actual" named param to assert test cases for consistency since "expected" was included.
/azp run |
Azure Pipelines successfully started running 2 pipeline(s). |
Why make this change?
dab start {options}
may contain fully valid values, but when used as arguments to start the DAB engine process within CLI, engine startup fails. The failure didn't get reflected as error code -1.dab init {options}
may reference a file that already exists in the path that the CLI uses to read/write config files, this results in an error that is not properly reflected in the exit code.What is this change?
0
success-1
failureisSuccess
within theoptions.Handler()
methods, the handler methods all return the int error code now.How was this tested?