Making datasourcename mandatory during executequeryasync for multi-db scenario. #2112
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rohkhann
requested review from
mbhaskar,
Aniruddh25,
JelteF,
seantleonard,
Mathos1432,
gledis69,
aaronburtle,
tarazou9,
ayush3797,
abhishekkumams,
aaronpowell,
severussundar,
ravishetye,
neeraj-sharma2592 and
sourabh1007
as code owners
|
/azp run |
…mnDefinitionAsync
|
Azure Pipelines successfully started running 2 pipeline(s). |
|
/azp run |
|
Azure Pipelines successfully started running 2 pipeline(s). |
…nAsync' of https://github.com/Azure/data-api-builder into rohkhann/SetDataSourceNameDuringPopulateColumnDefinitionAsync
|
/azp run |
|
Azure Pipelines successfully started running 2 pipeline(s). |
|
/azp run |
|
Azure Pipelines successfully started running 2 pipeline(s). |
rusamant
approved these changes
Mar 18, 2024
rohkhann
deleted the
rohkhann/SetDataSourceNameDuringPopulateColumnDefinitionAsync
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why make this change?
During the call to executeQuery, if DataSource Name is not specified, the query will execute against the default dB. Currently this option is an optional argument. This can lead to caller not sending the DataSource Name as the method does not require it.
If used incorrectly, it will then execute against the default db which can lead to errors during multi-db scenario. For example, in SQLMetadataProvider, we have the queryexecutor call executequeryAsync for readonly columns. Currently, that does not specify the datasource as it is not required by the method. This means that will always execute against the default db, even though the datasourceName property is available on the SQLMetadataprovider which tells you which db to execute this query against.
currently we execute the query against the default db (this was done to maintain backward compatibility for single source scenarios). In this change, we make it mandatory to specify the datasource name during a call to executequeryAsync. String.Empty or null can be sent if query is to be executed against default db.
What is this change?
How was this tested?