Skip to content

Fix support for integer values in float/decimal type columns #2205

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 11 commits into from
May 13, 2024
Merged

Fix support for integer values in float/decimal type columns #2205

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
4c67e17
fix int float gql bug
abhishekkumams May 4, 2024
54f7ad0
adding tests
abhishekkumams May 8, 2024
7cf8ae4
Merge branch 'main' into dev/abhishekkuma/fix-int-float-error
abhishekkumams May 8, 2024
45cadbf
updating summary
abhishekkumams May 8, 2024
5331b1d
merging main
abhishekkumams May 8, 2024
928cdea
Merge branch 'main' into dev/abhishekkuma/fix-int-float-error
abhishekkumams May 9, 2024
599031c
updating parsing logic
abhishekkumams May 10, 2024
bb0f0ce
updating tests
abhishekkumams May 10, 2024
e4e96bb
Merge branch 'main' into dev/abhishekkuma/fix-int-float-error
abhishekkumams May 10, 2024
f9a68d7
Merge branch 'main' into dev/abhishekkuma/fix-int-float-error
Aniruddh25 May 10, 2024
6c271fc
Merge branch 'main' into dev/abhishekkuma/fix-int-float-error
abhishekkumams May 11, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions src/Core/Services/ExecutionHelper.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -318,9 +318,9 @@ private static bool TryGetPropertyFromParent(
SupportedHotChocolateTypes.SHORT_TYPE => ((IntValueNode)value).ToInt16(),
SupportedHotChocolateTypes.INT_TYPE => ((IntValueNode)value).ToInt32(),
SupportedHotChocolateTypes.LONG_TYPE => ((IntValueNode)value).ToInt64(),
SupportedHotChocolateTypes.SINGLE_TYPE => ((FloatValueNode)value).ToSingle(),
SupportedHotChocolateTypes.FLOAT_TYPE => ((FloatValueNode)value).ToDouble(),
SupportedHotChocolateTypes.DECIMAL_TYPE => ((FloatValueNode)value).ToDecimal(),
SupportedHotChocolateTypes.SINGLE_TYPE => value is IntValueNode intValueNode ? intValueNode.ToSingle() : ((FloatValueNode)value).ToSingle(),
SupportedHotChocolateTypes.FLOAT_TYPE => value is IntValueNode intValueNode ? intValueNode.ToDouble() : ((FloatValueNode)value).ToDouble(),
SupportedHotChocolateTypes.DECIMAL_TYPE => value is IntValueNode intValueNode ? intValueNode.ToDecimal() : ((FloatValueNode)value).ToDecimal(),
SupportedHotChocolateTypes.UUID_TYPE => Guid.TryParse(value.Value!.ToString(), out Guid guidValue) ? guidValue : value.Value,
_ => value.Value
};
Expand Down
18 changes: 18 additions & 0 deletions src/Service.Tests/SqlTests/GraphQLSupportedTypesTests/GraphQLSupportedTypesTestsBase.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -325,6 +325,7 @@ public async Task TestTimeTypePrecisionCheck(string gqlValue, int count)
[DataRow(STRING_TYPE, "null")]
[DataRow(SINGLE_TYPE, "-3.33")]
[DataRow(SINGLE_TYPE, "2E35")]
[DataRow(SINGLE_TYPE, "123")]
[DataRow(SINGLE_TYPE, "null")]
[DataRow(FLOAT_TYPE, "-3.33")]
[DataRow(FLOAT_TYPE, "2E150")]
Expand Down Expand Up @@ -413,8 +414,15 @@ public async Task InsertInvalidTimeIntoTimeTypeColumn(string type, string value)
[DataRow(INT_TYPE, 9999)]
[DataRow(LONG_TYPE, 9000000000000000000)]
[DataRow(STRING_TYPE, "aaaaaaaaaa")]
[DataRow(SINGLE_TYPE, 123.1)]
[DataRow(SINGLE_TYPE, 123)]
[DataRow(SINGLE_TYPE, null)]
[DataRow(FLOAT_TYPE, -3.33)]
[DataRow(FLOAT_TYPE, 123)]
[DataRow(FLOAT_TYPE, null)]
[DataRow(DECIMAL_TYPE, 1222222.00000929292)]
[DataRow(DECIMAL_TYPE, 123)]
[DataRow(DECIMAL_TYPE, null)]
[DataRow(BOOLEAN_TYPE, true)]
[DataRow(DATETIMEOFFSET_TYPE, "1999-01-08 10:23:54+8:00")]
[DataRow(DATETIME_TYPE, "1999-01-08 10:23:54")]
Expand Down Expand Up @@ -464,13 +472,16 @@ public async Task InsertIntoTypeColumnWithArgument(string type, object value)
[DataRow(STRING_TYPE, "null")]
[DataRow(SINGLE_TYPE, "-3.33")]
[DataRow(SINGLE_TYPE, "2E35")]
[DataRow(SINGLE_TYPE, "123")]
[DataRow(SINGLE_TYPE, "null")]
[DataRow(FLOAT_TYPE, "-3.33")]
[DataRow(FLOAT_TYPE, "2E150")]
[DataRow(FLOAT_TYPE, "null")]
[DataRow(FLOAT_TYPE, "123")]
[DataRow(DECIMAL_TYPE, "-3.333333")]
[DataRow(DECIMAL_TYPE, "1222222.00000929292")]
[DataRow(DECIMAL_TYPE, "null")]
[DataRow(DECIMAL_TYPE, "123")]
[DataRow(BOOLEAN_TYPE, "true")]
[DataRow(BOOLEAN_TYPE, "false")]
[DataRow(BOOLEAN_TYPE, "null")]
Expand Down Expand Up @@ -512,8 +523,15 @@ public async Task UpdateTypeColumn(string type, string value)
[DataRow(INT_TYPE, 9999)]
[DataRow(LONG_TYPE, 9000000000000000000)]
[DataRow(STRING_TYPE, "aaaaaaaaaa")]
[DataRow(SINGLE_TYPE, 2E35)]
[DataRow(SINGLE_TYPE, 123)]
[DataRow(SINGLE_TYPE, null)]
[DataRow(FLOAT_TYPE, -3.33)]
[DataRow(FLOAT_TYPE, 123)]
[DataRow(FLOAT_TYPE, null)]
[DataRow(DECIMAL_TYPE, 1222222.00000929292)]
[DataRow(DECIMAL_TYPE, 123)]
[DataRow(DECIMAL_TYPE, null)]
[DataRow(BOOLEAN_TYPE, true)]
[DataRow(DATETIME_TYPE, "1999-01-08 10:23:54")]
[DataRow(DATETIMEOFFSET_TYPE, "1999-01-08 10:23:54+8:00")]
Expand Down