Adding Sql pool is warming up error code to list of transient exceptions #2241
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ons to ensure retry logic executes for DW.
rohkhann
requested review from
mbhaskar,
Aniruddh25,
seantleonard,
Mathos1432,
gledis69,
aaronburtle,
tarazou9,
ayush3797,
abhishekkumams,
aaronpowell,
severussundar,
ravishetye,
neeraj-sharma2592 and
sourabh1007
as code owners
|
/azp run |
seantleonard
approved these changes
May 30, 2024
rusamant
approved these changes
May 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why make this change?
Datawarehouse's can have cold start up issues leading to sql error: The SQL pool is warming up. Please try again.
This is a transient exception and the recommendation is to just retry and connect back to the server:https://github.com/MicrosoftDocs/sql-docs/blob/live/docs/relational-databases/errors-events/mssqlserver-42109-database-engine-error.md.
What is this change?
This change adds the error code for the Sql pool is warming up into the transient error code list, ensuring the retry logic comes into play if this error comes up. For the code please see: https://github.com/dotnet/efcore/blob/main/src/EFCore.SqlServer/Storage/Internal/SqlServerTransientExceptionDetector.cs
How was this tested?