-
Notifications
You must be signed in to change notification settings - Fork 279
Add MaxResponseSizeMB to runtime config. #2242
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add MaxResponseSizeMB to runtime config. #2242
Conversation
/azp run |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When i have a dab-config.json where i set "max-response-size-mb": null
and then run DAB's CLI -> dab add Book --config "path/to/config.json" --source books --permissions "anonymous:create,read,update,delete" --graphql "book:books"
The field "max-response-size-mb"
disappears from my config.
The use case is this: I am explicitly setting the property and value in my config. I am saying: "i want no limit to max response size, do NOT give me DAB's default value as that could change in the future. My config is explicitly telling dab what i want and the CLI shouldn't remove my explicitly defined field."
Added similar flow to pagination options. Added all the things discussed in design doc. |
…ttps://github.com/Azure/data-api-builder into dev/rohkhann/AddingInMaxResponseSizeToRuntimeConfig
/azp run |
/azp run |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
last two nits on comments. Thanks for making these changes!
/azp run |
Why make this change?
This change adds in a new property to the host parameter of runtime config called MaxResponseSizeMB. This property will allow users to configure the amount of data that their host platform's memory can handle when streaming data from the underlying datasources.
What is this change?
This change adds the maxresponseSizeMB property to the runtime config. In addition, it adds an accessor for that property which would be needed to implement the actual logic of streaming.
How was this tested?
Unit tests are added.