-
Notifications
You must be signed in to change notification settings - Fork 279
Add new cli command to update runtime with graphql depth limit #2250
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
abhishekkumams
merged 14 commits into
main
from
dev/abhishekkuma/add-update-runtime-command-cli-depth-limit
Jun 13, 2024
Merged
Add new cli command to update runtime with graphql depth limit #2250
abhishekkumams
merged 14 commits into
main
from
dev/abhishekkuma/add-update-runtime-command-cli-depth-limit
Jun 13, 2024
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
seantleonard
requested changes
Jun 6, 2024
aaronburtle
reviewed
Jun 7, 2024
… dev/abhishekkuma/add-update-runtime-command-cli-depth-limit
/azp run |
seantleonard
approved these changes
Jun 12, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
few nits but once cleaned up, looks good!
Co-authored-by: Sean Leonard <sean.leonard@microsoft.com>
Co-authored-by: Sean Leonard <sean.leonard@microsoft.com>
Co-authored-by: Sean Leonard <sean.leonard@microsoft.com>
aaronburtle
reviewed
Jun 12, 2024
…imit' of https://github.com/Azure/data-api-builder into dev/abhishekkuma/add-update-runtime-command-cli-depth-limit
/azp run |
aaronburtle
approved these changes
Jun 13, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the quick responses.
/azp run |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why make this change?
What is this change?
dab configure
, which will allow updates for non-entity based config settings.--runtime.graphql.depth-limit
, which will be used to specify the depth limit for GraphQL queries and mutation.example:
dab configure --runtime.graphql.depth-limit 20
.NOTE:
if limit is not already specified, it will add this property to config, else update it.
dab configure --runtime.graphql.depth-limit -1
How was this tested?
Sample Request(s)
initial config
command:
dab configure --runtime.graphql.depth-limit 20
command:
dab configure --runtime.graphql.depth-limit 8
command:
dab configure --runtime.graphql.depth-limit -1
Special Case:
if value of "depth-limit" is null in the config. it will stay as is, if not updated.
command:
dab configure
No change: