Skip to content

Fixed duplicate datarow issue #2261

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jun 13, 2024
Merged

Fixed duplicate datarow issue #2261

merged 3 commits into from
Jun 13, 2024

Conversation

Surya056
Copy link
Contributor

@Surya056 Surya056 commented Jun 11, 2024 •
edited
Loading

Why make this change?

What is this change?

  • modified the duplicate SMALLDATETIME_TYPE and DisplayName for the DataRow to Sequential values.

How was this tested?

  • Integration Tests
  • Unit Tests

@seantleonard
Copy link
Contributor

/azp run

@azure-pipelines Azure Pipelines
Copy link

Commenter does not have sufficient privileges for PR 2261 in repo Azure/data-api-builder

@Surya056
Copy link
Contributor Author

@seantleonard - Can you please check and let me know if any changes need to be made? Thank you!

@seantleonard
Copy link
Contributor

/azp run

aaronburtle
aaronburtle approved these changes Jun 12, 2024
View reviewed changes
Copy link
Contributor

@aaronburtle aaronburtle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing this!

@Surya056
Copy link
Contributor Author

Hi @seantleonard - there is a unit test check that failed which is not related to this change, can you please help me close this issue?

@seantleonard
Copy link
Contributor

/azp run

@seantleonard seantleonard enabled auto-merge (squash) June 13, 2024 15:39
@seantleonard
Copy link
Contributor

Hi @Surya056, yes, there was #2264 I needed to merge to get this working. Merged now at set your PR to auto-merge. Thank you again for your contribution!

@seantleonard seantleonard merged commit 0fffd96 into Azure:main Jun 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@seantleonard seantleonard seantleonard approved these changes

@aaronburtle aaronburtle aaronburtle approved these changes

@mbhaskar mbhaskar Awaiting requested review from mbhaskar

@Aniruddh25 Aniruddh25 Awaiting requested review from Aniruddh25 Aniruddh25 is a code owner

@Mathos1432 Mathos1432 Awaiting requested review from Mathos1432

@gledis69 gledis69 Awaiting requested review from gledis69

@tarazou9 tarazou9 Awaiting requested review from tarazou9

@ayush3797 ayush3797 Awaiting requested review from ayush3797

@abhishekkumams abhishekkumams Awaiting requested review from abhishekkumams

@aaronpowell aaronpowell Awaiting requested review from aaronpowell

@severussundar severussundar Awaiting requested review from severussundar

@ravishetye ravishetye Awaiting requested review from ravishetye

@rohkhann rohkhann Awaiting requested review from rohkhann

@neeraj-sharma2592 neeraj-sharma2592 Awaiting requested review from neeraj-sharma2592 neeraj-sharma2592 is a code owner

@sourabh1007 sourabh1007 Awaiting requested review from sourabh1007 sourabh1007 is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Test Bug] Fix GraphQLSupportTypesTestsBase.cs datarows for QueryTypeColumn test.
3 participants
@Surya056 @seantleonard @aaronburtle