Fix MySQL test execution time + Fix DateTime GraphQL input handling

[seantleonard]

Why make this change?

I discovered another bug while working on this change #2268, which will be addressed separately.

What is this change?

• Fixes a bug where GraphQL DateTime input with Timezone (TZ) offset was not honored.

  • e.g. 12-31-2024T12:00:00+03:00 was stored as 12-31-2024T12:00:00 in the backend database instead of 12-31-2024T09:00:00
  • This bug was discovered because some SupportedTypes tests involving dates always failed locally but not in the integration test pipeline. My local machine in UTC-8 while pipelines are UTC. Additionally, some test input 9999-12-31 23:59:59.9999999 was run for MySql where that value is an invalid date (max decimal is .499999).

• Fixes false negative (passing) test cases in GraphQLSupportedTypesTests by adding more comprehensive asserts, updating DataRow test input, and ensuring tests specific to a database type are correctly executed.

  • As a result, MySQL tests in this specific test suite run way faster (~minutes down to less than 10 seconds because the conclusion of each data row execution doesn't reset the MySql database contents which takes a long time via ResetDbStateAsync().)
  • Updates test code queries and mutations to include the primary key (typeid) of the table type_table so that tests interact with determinate records:

  string gqlQuery = "{ supportedType_by_pk(typeid: " + id + ") { typeid, " + field + " } }";

• A bug in the test

// Old test
[DataRow(TIME_TYPE, "\"23:59:59.9999999\"")]

// Fixed Test
[DataRow(TIME_TYPE, "23:59:59")]
public async Task InsertIntoTypeColumnWithArgument(string type, object value)

This test shows as green in main branch. However, looking at the log of the test, I saw this error:

GraphQL error: [{"message":"The variable `param` is not compatible with the type of the current location.","locations":[{"line":1,"column":65}],"path":["createSupportedType"],"extensions":{"variable":"param","variableType":"Time","locationType":"LocalTime","specifiedBy":"http://spec.graphql.org/October2021/#sec-All-Variable-Usages-are-Allowed"}}]

There are two layers of changes here:

1. TIME_TYPE is technically not a GraphQL data type recognized or defined by DAB's generated GraphQL schema/ HotChocolate -> LocalTime is. So when the data row for TIME_TYPE comes in this code resolves the expected type:

        private static string TypeNameToGraphQLType(string typeName)
        {
            return typeName switch
            {
                DATETIMEOFFSET_TYPE => DATETIME_TYPE,
                TIME_TYPE => LOCALTIME_TYPE,
                _ => typeName
            };
        }

2. Leaving quotes on the value -> \"23:59:59.9999999\" in results in the error:

GraphQL error: [{"message":"Unable to deserialize string to LocalTime","path":["param"]}]

why keep data row as "TIME_TYPE"? well, our test code resolves that type name not only as the GraphQL type but also as a way to determine which column in the data source to select which is named time_types. So we'd need to decouple the GraphQL Data Type value from being used to determine the SQL table column name.

How was this tested?

• Integration Tests - Fixed tests in GraphQLSupportedTypesTests

[seantleonard]

/azp run

[ayush3797]

Neat! LGTM!

[Aniruddh25]

Comments so far

[abhishekkumams]

/azp run

[abhishekkumams]

/azp run

[Aniruddh25]

Left few questions. But approved otherwise.

[abhishekkumams]

/azp run

[abhishekkumams]

/azp run

[abhishekkumams]

/azp run