Cultural Invariant Conversion of datatypes during mutation #2307
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sourabh1007
requested review from
Aniruddh25,
seantleonard,
Mathos1432,
aaronburtle,
abhishekkumams,
ravishetye,
rohkhann and
neeraj-sharma2592
as code owners
|
/azp run |
|
please explain why this works, what's the behavior before/after. |
It is just for the sake of description, or it is a question, because changes are not clear enough? I have test cases added for this, you can refer that, that test case will fail, if you run it with |
|
/azp run |
sourabh1007
force-pushed
the
users/sourabhjain/culturalbug
branch
from
d18bffc to
34ba19c
Compare
seantleonard
requested changes
Jul 25, 2024
|
/azp run |
neeraj-sharma2592
approved these changes
Jul 26, 2024
|
/azp run |
seantleonard
approved these changes
Jul 31, 2024
seantleonard
pushed a commit
that referenced
this pull request
Aug 5, 2024
## Why make this change? It addresses #2284 bug raised by the customer. ## What is this change? Made sure datatype conversion is `CultureInfo.InvariantCulture` ## How was this tested? - [ ] Integration Tests - [ ] Unit Tests ## Sample Request(s) - Example REST and/or GraphQL request to demonstrate modifications - Example of CLI usage to demonstrate modifications
seantleonard
added a commit
that referenced
this pull request
Aug 8, 2024
…mutation (#2316) ## Port Metadata - porting from `main` to `release/1.2` - Issue: #2284 - PR: #2307 ## Why make this change? It addresses #2284 bug raised by the customer. ~~**Note:** Made change in`src/Core/Resolvers/SqlMutationEngine.cs` just for consistency.~~ [SL: this was in original PR, but is not accurate, since no changes to SqlMutationEngine.cs are included ## What is this change? Made sure datatype conversion is `CultureInfo.InvariantCulture` Co-authored-by: Sourabh Jain <sourabhjain@microsoft.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why make this change?
It addresses #2284 bug raised by the customer.
Note: Made change in
src/Core/Resolvers/SqlMutationEngine.csjust for consistency.What is this change?
Made sure datatype conversion is
CultureInfo.InvariantCultureHow was this tested?
Sample Request(s)