-
Notifications
You must be signed in to change notification settings - Fork 279
Handling nested inner objects for Cosmos Mutations #531
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…pport for "Update" entity for Cosmos.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Requesting more unit test..
DataGateway.Service.Tests/GraphQLBuilder/MutationBuilderTests.cs
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Waiting on resolution of [StarConnection] vs [Star]
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thanks for addressing my questions :)
DataGateway.Service.GraphQLBuilder/Mutations/UpdateMutationBuilder.cs
Outdated
Show resolved
Hide resolved
- Nested @model definitions shouldn't be supported, otherwise the engine will need to find some way to extract that out - Added Snapshooter to make testing a generated GraphQL schema a lot easier - Note - Snapshooter is used by HotChocolate extensively in its tests - Snapshooter hasn't shipped a NuGet package for MSTest support, so code is embedded (I wrote the MSTest support so I know it works!) - Added tests and their snapshots for the GraphQL schema structures that need to be covered
Why This Change
What changes were made
CreateMutationBuilder
andUpdateMutationBuilder
for the input type generations.CosmosMutationEngine
for saving data to the database.How was it tested?