Update to autorest 2 and dotnet 2.0 #104
Conversation
There was a problem hiding this comment.
Seems like this is not the right fix based on the PR Azure/azure-rest-api-specs#1884 that is having the other issue.
Let's talk to Johannes and find out what .NET core version are we supposed to use and then may be need to change the command as well.
vladbarosan
force-pushed
the
fix-build
branch
9 times, most recently
from
652f4c3 to
be8cb3e
Compare
.travis.yml
Outdated
| - npm install -g npm@'>=5.4.0' | ||
| - curl https://packages.microsoft.com/keys/microsoft.asc | gpg --dearmor > microsoft.gpg | ||
| - sudo mv microsoft.gpg /etc/apt/trusted.gpg.d/microsoft.gpg | ||
| - sudo sh -c 'echo "deb [arch=amd64] https://packages.microsoft.com/repos/microsoft-ubuntu-trusty-prod trusty main" > /etc/apt/sources.list.d/dotnetdev.list' |
There was a problem hiding this comment.
try out sudo apt-get install nodejs specific version you want
There was a problem hiding this comment.
That wont work properly. To properly install a specific major version of nodejs you need to run a remote script like https://deb.nodesource.com/setup_8.x and after that to run sudo apt-get install nodejs.
We can do both, only that that way we won't have much granularity in the version used ( in case we care )
| <OutputType>Exe</OutputType> | ||
| <TargetFrameworks>netcoreapp1.0</TargetFrameworks> | ||
| <TargetFramework>netcoreapp1.0</TargetFramework> | ||
| <TargetFramework>netcoreapp2.0</TargetFramework> |
There was a problem hiding this comment.
try to move this also to netstandard2.0 if we can
There was a problem hiding this comment.
For exe type we cannot use netstandard2.0 ( intended only for libraries). Since we are using this dill like an executable we need to stay to netcoreapp2.0
| <Import Project="$(common)project-xunittest.proj" /> | ||
|
|
||
| <PropertyGroup> | ||
| <OutputType>Exe</OutputType> | ||
| <TargetFramework>netcoreapp1.0</TargetFramework> | ||
| <TargetFramework>netcoreapp2.0</TargetFramework> |
There was a problem hiding this comment.
Same as previous comment. since the unit test project is an exe we need to keep netcoreapp2.0
vishrutshah
dismissed
their stale review
I'll let @veronicagg look at it in details
vladbarosan
force-pushed
the
fix-build
branch
from
6f0ed83 to
2103284
Compare
.travis.yml
Outdated
| sudo apt-get install dotnet-dev-1.0.0-rc4-004769 -y | ||
| - rm -rf ~/.nvm && git clone https://github.com/creationix/nvm.git ~/.nvm && (cd ~/.nvm && git checkout `git describe --abbrev=0 --tags`) && source ~/.nvm/nvm.sh && nvm install 7.10.0 | ||
| - npm install -g npm@'>=5.4.0' | ||
| - curl https://packages.microsoft.com/keys/microsoft.asc | gpg --dearmor > microsoft.gpg |
There was a problem hiding this comment.
you may want to add a comment on why these lines are needed and maybe a pointer to where you got the pre-reqs from
vladbarosan
force-pushed
the
fix-build
branch
2 times, most recently
from
5a622d3 to
62a4db9
Compare
vladbarosan
force-pushed
the
fix-build
branch
from
62a4db9 to
dacc391
Compare
vladbarosan
force-pushed
the
fix-build
branch
from
dacc391 to
a79447f
Compare
Trying to address #105