bugfixes #250
Merged
bugfixes #250
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mikekistler
requested changes
Oct 17, 2022
There was a problem hiding this comment.
I left a few questions and comments.
It took me some time to figure out exactly what problems this PR was addresing. The referenced issues were extremely terse. I could have used a bit more context in the PR description. This is also why I asked for more focused test files.
openapi-diff/src/modeler/AutoRest.Swagger.Tests/SwaggerModelerCompareTests.cs
Outdated
Show resolved
Hide resolved
Comment on lines
10
to
33
| "/api/Parameters": { | ||
| "put": { | ||
| "tags": [ "Parameters" ], | ||
| "operationId": "Parameters_Put", | ||
| "produces": [ | ||
| "text/plain" | ||
| ], | ||
| "parameters": [ | ||
| { | ||
| "name": "database", | ||
| "in": "body", | ||
| "required": true, | ||
| "schema": { "$ref": "#/definitions/DatabaseRenamed" } | ||
| } | ||
| ], | ||
| "responses": { | ||
| "200": { | ||
| "schema":{ | ||
| "$ref": "#/definitions/DatabaseRenamed" | ||
| } | ||
| } | ||
| } | ||
| } | ||
| } |
There was a problem hiding this comment.
I think the test files should be "minimal" -- contain only what is needed to exercise the particular check being tested.
I don't think any of this is needed for the test.
Suggested change
| "/api/Parameters": { | |
| "put": { | |
| "tags": [ "Parameters" ], | |
| "operationId": "Parameters_Put", | |
| "produces": [ | |
| "text/plain" | |
| ], | |
| "parameters": [ | |
| { | |
| "name": "database", | |
| "in": "body", | |
| "required": true, | |
| "schema": { "$ref": "#/definitions/DatabaseRenamed" } | |
| } | |
| ], | |
| "responses": { | |
| "200": { | |
| "schema":{ | |
| "$ref": "#/definitions/DatabaseRenamed" | |
| } | |
| } | |
| } | |
| } | |
| } |
...rc/modeler/AutoRest.Swagger.Tests/Resource/Swagger/old/property_required_status_changed.json
Outdated
Show resolved
Hide resolved
...rc/modeler/AutoRest.Swagger.Tests/Resource/Swagger/old/property_required_status_changed.json
Outdated
Show resolved
Hide resolved
openapi-diff/src/modeler/AutoRest.Swagger.Tests/SwaggerModelerCompareTests.cs
Show resolved
Hide resolved
…CompareTests.cs Co-authored-by: Mike Kistler <mikekistler@microsoft.com>
jianyexi
commented
Oct 18, 2022
|
|
||
| // Verify a inline schema of response was changed to reference schema and a new proeprty was added. | ||
| [Fact] | ||
| public void AddedOptionalPropertyToInlineResponseSchema() |
There was a problem hiding this comment.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix: don't report error when response schema changed #248
fix No difference reported for required property changed to optional #207
fix Ref model change for property, array item or map items should be a breaking change #233