Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add PreferredAuthMethod to interactive token flow #1964

Merged
merged 13 commits into from
Jan 17, 2024

Conversation

p3dr0rv
Copy link
Collaborator

@p3dr0rv p3dr0rv commented Nov 30, 2023

Why

With the introduction of the QR + PIN Auth method a new query string parameter was added.
Preferred authorization method = pc.
This parameter will be passed to the authorization endpoint to indicate the preferred authorization method for a request. (for QR + PIN Auth the code is 18)
If this parameter is present ESTS will read the code and will return a UX according to the specified pc.
If this parameter is not present the behavior will be the same, we have now.

Changes

  • Add PreferredAuthMethod to AcquireTokenParameters.
  • Pass the data on the CommandParametersAdapter.
  • Add button on MSALTestApp to test this flow.

Related PR's

https://github.com/AzureAD/ad-accounts-for-android/pull/2630
AzureAD/microsoft-authentication-library-common-for-android#2245

@p3dr0rv p3dr0rv changed the title [WIP] token params for qr Add PreferredAuthMethod to interactive token flow Dec 1, 2023
@p3dr0rv p3dr0rv marked this pull request as ready for review December 1, 2023 23:27
@p3dr0rv p3dr0rv requested a review from a team as a code owner December 1, 2023 23:27
p3dr0rv added a commit to AzureAD/microsoft-authentication-library-common-for-android that referenced this pull request Jan 17, 2024
## Why
With the introduction of the QR + PIN Auth method a new query string
parameter was added.
Preferred authorization method = pc.
This parameter will be passed to the authorization endpoint to indicate
the preferred authorization method for a request. (for QR + PIN Auth the
code is 18)
If this parameter is present ESTS will read the code and will return a
UX according to the specified pc.
If this parameter is not present the behavior will be the same, we have
now.

## Changes

* Add PreferredAuthMethod to InteractiveTokenCommandParameters,
MicrosoftAuthorizationRequest and BrokerRequest to be transported
through the flow.
* Pass the data on the controllers.


## Related PR's
AzureAD/ad-accounts-for-android#2630

AzureAD/microsoft-authentication-library-for-android#1964
@p3dr0rv p3dr0rv merged commit 9499035 into dev Jan 17, 2024
9 checks passed
@p3dr0rv p3dr0rv deleted the pedroro/token-params-for-qr branch January 17, 2024 00:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants