Add PreferredAuthMethod to interactive token flow #1964
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
p3dr0rv
changed the title
fadidurah
approved these changes
Dec 4, 2023
rpdome
approved these changes
Jan 4, 2024
msal/src/main/java/com/microsoft/identity/client/AcquireTokenParameters.java
Show resolved
Hide resolved
msal/src/main/java/com/microsoft/identity/client/AcquireTokenParameters.java
Show resolved
Hide resolved
p3dr0rv
added a commit
to AzureAD/microsoft-authentication-library-common-for-android
that referenced
this pull request
Jan 17, 2024
## Why With the introduction of the QR + PIN Auth method a new query string parameter was added. Preferred authorization method = pc. This parameter will be passed to the authorization endpoint to indicate the preferred authorization method for a request. (for QR + PIN Auth the code is 18) If this parameter is present ESTS will read the code and will return a UX according to the specified pc. If this parameter is not present the behavior will be the same, we have now. ## Changes * Add PreferredAuthMethod to InteractiveTokenCommandParameters, MicrosoftAuthorizationRequest and BrokerRequest to be transported through the flow. * Pass the data on the controllers. ## Related PR's AzureAD/ad-accounts-for-android#2630 AzureAD/microsoft-authentication-library-for-android#1964
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
With the introduction of the QR + PIN Auth method a new query string parameter was added.
Preferred authorization method = pc.
This parameter will be passed to the authorization endpoint to indicate the preferred authorization method for a request. (for QR + PIN Auth the code is 18)
If this parameter is present ESTS will read the code and will return a UX according to the specified pc.
If this parameter is not present the behavior will be the same, we have now.
Changes
Related PR's
https://github.com/AzureAD/ad-accounts-for-android/pull/2630
AzureAD/microsoft-authentication-library-common-for-android#2245