making api more consistent and expressive #1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
henrik-me
reviewed
Jan 19, 2019
| * Token, Refresh Token and the Access Token's expiration time. | ||
| */ | ||
| public CompletableFuture<AuthenticationResult> acquireToken(String scopes, String username) { | ||
| public CompletableFuture<AuthenticationResult> acquireTokenByKerberosAuth(String scopes, String username) { |
There was a problem hiding this comment.
yKerberosAuth [](start = 64, length = 13)
Isn't this called IntegratedWindowsAuth in the .NET SDK?
There was a problem hiding this comment.
yes, but these cased are different , Kerberos is platform agnostic
sangonzal
approved these changes
Jan 22, 2019
| * property will be null for this overload. | ||
| */ | ||
| public CompletableFuture<AuthenticationResult> acquireToken(final String scopes) { | ||
| public CompletableFuture<AuthenticationResult> acquireTokenForClient(String scopes) { |
There was a problem hiding this comment.
acquireTokenForClient seems a bit redundant. Is there a reason why we want to swtich from acquireToken to acquireTokenForClient?
There was a problem hiding this comment.
to be consistent with .NET naming
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Making api more consistent and expressive