Refactoring to suppress CodeQL false positives #910
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#904 added suppressions for various CodeQL issues described in #899, however, after it was merged into main and scanned again two of the issues were still not suppressed.
This PR does some small refactoring to try to suppress the remaining false-positive flags:
DefaultHttpClientManagedIdentity
: the suppression comment was originally above the flagged variable, though the behavior that caused the flag was assigned to the variable elsewhereCookieHelper
and the same suppression comment was added to both lines of flagged code, however only one of the flags were suppressed