Skip to content

Conversation

Avery-Dunn
Copy link
Contributor

@Avery-Dunn Avery-Dunn requested a review from a team as a code owner June 5, 2025 22:12
changelog.txt Outdated
@@ -1,3 +1,11 @@
Version 1.21.0
=============
- Add support for claims and client capabilities in Managed Identity scenarios (#929, #943)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@gladjohn - can this be merged now?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The new public claims/capabilities APIs were added in #929 and already released, and #943 added the actual behavior behind those APIs just in Service Fabric

Maybe the changelog should say "Add support for claims and client capabilities in Service Fabric scenarios" to be more clear? Because if it isn't actually ready for release that should've been mentioned in the PRs

Version 1.21.0
=============
- Add support for claims and client capabilities in Managed Identity scenarios (#929, #943)
- Improve retry logic for HTTP requests, and add API to disable retries (#960, #963, #964)
Copy link
Member

@bgavrilMS bgavrilMS Jun 6, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please inform Vinay about this new API, otherwise it's going to be a breaking change for them if they don't use the API.

Copy link
Contributor Author

@Avery-Dunn Avery-Dunn Jun 6, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are you saying that having IMDS scenarios retry on a couple of different status codes from normal managed identity is considered a breaking change? If so, why would it only be a problem for Azure SDK?

Other than the status codes for IMDS it was just a refactor of the existing retry behavior, and a new API to disable that behavior

changelog.txt Outdated
@@ -1,3 +1,11 @@
Version 1.21.0
=============
- Add support for claims and client capabilities in Service Fabric scenarios (#929, #943)

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe mention "token revocation" in some way?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just changed it to "Add support for claims, client capabilities, and token revocation in Service Fabric scenarios"

@Avery-Dunn Avery-Dunn merged commit 15e26ca into dev Jun 6, 2025
5 checks passed
@Avery-Dunn Avery-Dunn deleted the avdunn/release-1.21.0 branch September 15, 2025 14:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants