Add allowRedirectInIframe flag to browser #2593
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jasonnutter
commented
Nov 12, 2020
change/@azure-msal-browser-2020-11-12-15-38-05-allowRedirectInIframe.json
Outdated
Show resolved
Hide resolved
tnorling
approved these changes
Nov 23, 2020
jmckennon
approved these changes
Nov 30, 2020
5 tasks
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By default, MSAL will block redirect operations if they are done inside an iframe, as we know the server will not support rendering the login UX in an iframe. However, there is at least one notable expection, the B2C embedded login UX feature (where the B2C login UI is allowed to be rendered inside an iframe), where invoking loginRedirect inside an iframe needs to be supported. This flag enables applications to opt out of that check if they know they need this functionality.