Fix clearing of temporary cache items #2696
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tnorling
requested review from
DarylThayil,
hectormmg,
jasonnutter,
jmckennon,
jo-arroyo,
pkanher617 and
sameerag
as code owners
github-actions
bot
added
msal-browser
3 tasks
jasonnutter
approved these changes
Dec 4, 2020
jo-arroyo
approved these changes
Dec 7, 2020
pkanher617
approved these changes
Dec 7, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A regression was introduced when
statewas added to the temporary cache keys, resulting in temporary cache items not being cleared whenstatewas unavailable. For instance when clicking the back button during a redirect or when closing the parent window during loginPopup.This PR fixes this by adding another
cleanRequestfunction for use in situations where state is unknown. This new function takes in the interaction type and searches the cache for a state value that has this interactionType and then uses all matching state values to clear the relevant temporary cache entries.