Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update node version support in package.json #2998

Merged
merged 15 commits into from
Feb 17, 2021
Merged

Conversation

sameerag
Copy link
Member

@sameerag sameerag commented Feb 9, 2021

Introducing "engines" in package.json for msal-node to update Node.js version support.

 "engines" : {
    "node" : ">=14.0.0"
  }

@github-actions github-actions bot added the msal-node Related to msal-node package label Feb 9, 2021
@coveralls
Copy link

coveralls commented Feb 9, 2021

Coverage Status

Coverage increased (+12.05%) to 94.757% when pulling 6dc525f on add-node-version-support into 4ec58c4 on dev.

lib/msal-node/package.json Outdated Show resolved Hide resolved
@hectormmg hectormmg added this to the @azure/msal-node@1.0.0 milestone Feb 16, 2021
@jasonnutter
Copy link
Contributor

Per our discussion last night, can we add a table to the readme (similar msal-angular) where we detailed which versions of Node are supported in which versions of MSAL Node? I think our policy should be when a major version of MSAL Node is released as stable, it should support all LTS and active versions (today that is 10-15, as done in this PR), drop support for any previously supported Node versions that have reached end of life, and should not support prerelease/preview/pending versions until they are stable, as denoted here: https://nodejs.org/en/about/releases/

@github-actions github-actions bot added the documentation Related to documentation. label Feb 17, 2021
sameerag and others added 3 commits February 17, 2021 11:29
Co-authored-by: Jason Nutter <janutter@microsoft.com>
Co-authored-by: Jason Nutter <janutter@microsoft.com>
Co-authored-by: Jason Nutter <janutter@microsoft.com>
sameerag and others added 4 commits February 17, 2021 15:11
Co-authored-by: Jason Nutter <janutter@microsoft.com>
Co-authored-by: Jason Nutter <janutter@microsoft.com>
@sameerag sameerag merged commit 6c997ad into dev Feb 17, 2021
@sameerag sameerag deleted the add-node-version-support branch February 17, 2021 23:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Related to documentation. msal-node Related to msal-node package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants