-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Extend proactive token refresh to client_credentials #6102
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Robbie-Microsoft
requested review from
sameerag,
tnorling,
hectormmg,
peterzenz,
jennyf19,
jmprieur and
bgavrilMS
as code owners
June 7, 2023 18:28
bgavrilMS
reviewed
Jun 7, 2023
bgavrilMS
reviewed
Jun 7, 2023
bgavrilMS
requested changes
Jun 7, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not implemented as availability feature.
bgavrilMS
reviewed
Jun 9, 2023
bgavrilMS
reviewed
Jun 9, 2023
bgavrilMS
reviewed
Jun 9, 2023
bgavrilMS
reviewed
Jun 9, 2023
bgavrilMS
reviewed
Jun 9, 2023
Robbie-Microsoft
requested review from
jo-arroyo and
konstantin-msft
as code owners
June 10, 2023 16:58
bgavrilMS
reviewed
Jun 12, 2023
bgavrilMS
reviewed
Jun 12, 2023
bgavrilMS
reviewed
Jul 14, 2023
bgavrilMS
reviewed
Jul 14, 2023
bgavrilMS
reviewed
Jul 14, 2023
bgavrilMS
reviewed
Jul 14, 2023
bgavrilMS
reviewed
Jul 14, 2023
bgavrilMS
reviewed
Jul 14, 2023
bgavrilMS
reviewed
Jul 14, 2023
bgavrilMS
reviewed
Jul 14, 2023
bgavrilMS
reviewed
Jul 14, 2023
bgavrilMS
requested changes
Jul 14, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
RefreshOn is optional, not mandatory.
bgavrilMS
approved these changes
Jul 17, 2023
pmaytak
approved these changes
Jul 18, 2023
sameerag
reviewed
Aug 3, 2023
sameerag
reviewed
Aug 3, 2023
sameerag
reviewed
Aug 3, 2023
sameerag
approved these changes
Aug 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MSAL is expected to refresh the token when the refresh_in value expires. This is already implemented for AcquireTokenSilent but is not implemented for client_credentials. This PR implements refresh_in for client_credentials.
I've implemented the long term solution from the refresh spec.